opus-2
commented
5 years ago UPDATE: Doing further investigation, I have tried:
- reducing the config file to a minimum (as you can see in the logs below)
- tried connecting to another FTP server (completely different hardware, OS, software (ProFTPd), username, everything).
The results were exactly the same: the extension enters this "keep alive" mode by sending NOOP instructions every few seconds, but at the same time, sends hundreds of one-byte packets per second to the server, on port 21. So it's not the server, or the server software or the config file. That leaves me to think it's a bug in the extension.
Full log:
[debug] register command "Cancel All Transfer" from "./commandCancelAllTransfer.ts"
[debug] register command "Config" from "./commandConfig.ts"
[debug] register command "List Active Folder" from "./commandListActiveFolder.ts"
[debug] register command "Open Ssh Connection" from "./commandOpenSshConnection.ts"
[debug] register command "Set Profile" from "./commandSetProfile.ts"
[debug] register command "Toggle Output Panel" from "./commandToggleOutputPanel.ts"
[debug] register command "Upload Changed Files" from "./commandUploadChangedFiles.ts"
[debug] register command "Delete Remote" from "./fileCommandDeleteRemote.ts"
[debug] register command "Diff" from "./fileCommandDiff.ts"
[debug] register command "Diff Active File" from "./fileCommandDiffActiveFile.ts"
[debug] register command "Download" from "./fileCommandDownload.ts"
[debug] register command "Download Active File" from "./fileCommandDownloadActiveFile.ts"
[debug] register command "Download Active Folder" from "./fileCommandDownloadActiveFolder.ts"
[debug] register command "Download File" from "./fileCommandDownloadFile.ts"
[debug] register command "Download Folder" from "./fileCommandDownloadFolder.ts"
[debug] register command "Download Force" from "./fileCommandDownloadForce.ts"
[debug] register command "Download Project" from "./fileCommandDownloadProject.ts"
[debug] register command "Edit In Local" from "./fileCommandEditInLocal.ts"
[debug] register command "List" from "./fileCommandList.ts"
[debug] register command "List All" from "./fileCommandListAll.ts"
[debug] register command "Reveal In Explorer" from "./fileCommandRevealInExplorer.ts"
[debug] register command "Reveal In Remote Explorer" from "./fileCommandRevealInRemoteExplorer.ts"
[debug] register command "Sync Both Directions" from "./fileCommandSyncBothDirections.ts"
[debug] register command "Sync Local To Remote" from "./fileCommandSyncLocalToRemote.ts"
[debug] register command "Sync Remote To Local" from "./fileCommandSyncRemoteToLocal.ts"
[debug] register command "Upload" from "./fileCommandUpload.ts"
[debug] register command "Upload Active File" from "./fileCommandUploadActiveFile.ts"
[debug] register command "Upload Active Folder" from "./fileCommandUploadActiveFolder.ts"
[debug] register command "Upload File" from "./fileCommandUploadFile.ts"
[debug] register command "Upload Folder" from "./fileCommandUploadFolder.ts"
[debug] register command "Upload Force" from "./fileCommandUploadForce.ts"
[debug] register command "Upload Project" from "./fileCommandUploadProject.ts"
[info] config at s:\(project path) {"remotePath":"(path)","uploadOnSave":false,"downloadOnOpen":false,"ignore":[],"concurrency":1,"protocol":"ftp","connectTimeout":10000,"interactiveAuth":false,"secure":false,"passive":false,"remoteTimeOffsetInHours":0,"port":21,"host":"10.0.0.3","username":"******","password":"******"}
[trace] run command 'Upload File'
[trace] handle upload file for s:\(path)\local.ini
[debug] < '220 ProFTPD 1.3.4a Server (dio) [10.0.0.3]\r\n'
[debug] > USER fabio
[debug] < '331 Password required for fabio\r\n'
[debug] > PASS ******
[debug] < '230 User fabio logged in\r\n'
[debug] > FEAT
[debug] < '211-Features:\r\n MDTM\r\n MFMT\r\n TVFS\r\n MFF modify;UNIX.group;UNIX.mode;\r\n MLST modify*;perm*;size*;type*;unique*;UNIX.group*;UNIX.mode*;UNIX.owner*;\r\n REST STREAM\r\n SIZE\r\n211 End\r\n'
[debug] > TYPE I
[debug] < '200 Type set to I\r\n'
[debug] > PASV
[debug] < '227 Entering Passive Mode (10,0,0,3,156,187).\r\n'
[debug] > LIST /(path)
[debug] < '150 Opening BINARY mode data connection for file list\r\n'
[debug] < '226 Transfer complete\r\n'
[debug] > PASV
[debug] < '227 Entering Passive Mode (10,0,0,3,156,204).\r\n'
[debug] > STOR /(path)/local.ini
[debug] < '150 Opening BINARY mode data connection for /(path)/local.ini\r\n'
[debug] < '226 Transfer complete\r\n'
[debug] > MFMT 20181216224449 /(path)/local.ini
[debug] < '213 Modify=20181216224449; /(path)/local.ini\r\n'
[info] local -> remote s:\(path)\local.ini
[debug] > NOOP
[debug] > NOOP
[debug] > NOOP
[debug] > NOOP
[debug] > NOOP
liximomo
agiannis
sametpalitci
MikeWillis
JohnEPierce
Do you read the FAQ?
Describe the bug I've noticed my pure-ftpd server daemon (not sftp) getting flooded with small packets after a transfer is made. It seems to be some kind of keep-alive, but I'm getting several hundred packets per second.
After any transfer is done, in the output window, I see the extension starts sending a NOOP command every 8 seconds or so (which is good):
[debug] > NOOP [debug] < '200 Zzz...\r\n' [debug] > NOOP [debug] < '200 Zzz...\r\n'
BUT, at the same time, there are hundreds of 1-byte packets being sent to port 21. I'm the only client connected to my server and when I close vscode or reload window, this strange packet flow stops.
Here is one sample packet obtained with tcpdump on linux (they all look the same, 1 byte length - I get hundreds of these per second):
IMPORTANT: I have tried another FTP client (WinSCP on windows) and the problem doesn't happen with that program.
To Reproduce Steps to reproduce the behavior:
Expected behavior One NOOP every 8 seconds. Between those, sweet network silence.
Desktop (please complete the following information):
Extension Logs from Startup - required
problem starts here.