liximomo / vscode-sftp

Super fast sftp/ftp extension for VS Code
MIT License
1.5k stars 259 forks source link

VSCode doesn't work with this anymore in 1.45.1 #830

Open dylanh724 opened 3 years ago

dylanh724 commented 3 years ago

Do you read the FAQ?

Describe the bug Uploads fail: image

Error while signing data with privateKey: error:06000066:public key routines:OPENSSL_internal:DECODE_ERROR

To Reproduce Steps to reproduce the behavior:

  1. Save when it normally worked
  2. See fail in output.

Expected behavior File uploaded cleanly.

Screenshots See To Reproduce

Desktop (please complete the following information):

Extension Logs from Startup Out of time, sorry. The error output should hopefully do.

I saw other posts around already saying VSCode now requires some special ssh +extra setup that vscode-sftp does not follow such standards?

dylanh724 commented 3 years ago

similar, but why closed? Worked fine yesterday, updated, doesn't work >> https://github.com/liximomo/vscode-sftp/issues/594

Ben-Voris commented 3 years ago

This combination works for me with a couple of different SFTP servers.

Version: 1.49.2 (system setup)
Commit: e5e9e69aed6e1984f7499b7af85b3d05f9a6883a
Date: 2020-09-24T16:29:41.983Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.16299

with

Name: SFTP
Id: liximomo.sftp
Description: SFTP/FTP sync
Version: 1.12.9
Publisher: liximomo
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=liximomo.sftp
dylanh724 commented 3 years ago

Thanks, but this is a workaround ^ not a solution.

This is a breaking issue. Why is there no love to this thread? I saw there were others reported that were mysteriously closed without solution to a ghetto workaround that not every environment can do, usually involving downgrading or swapping out the key with a different type. All relevant closed have had 0 explanation and just mysteriously closed, despite numerous requests to reopen. @liximomo respectfully, why is this topic being avoided?

dylanh724 commented 3 years ago

Got it (Long-Term Workaround):

Thanks to @Timmmm:

  1. Download ssh2-streams-0.4.10-pemPatched.zip below using Tim's fix patched in.
  2. Go in top dir, then extract contents to %userprofile%\.vscode\extensions\liximomo.sftp-1.12.9\
  3. Restart vscode ssh2-streams-0.4.10-pemPatched.zip

Alternately

You could probably just update the node_module ssh2-streams - I heard they fixed it themselves.

@liximomo : This is not a fix

All the dev has to do is rebuild with the updated node module to fix this bug.

This is merely a workaround. Any updates from liximomo will break this workaround. That is, if that dev didn't abandon the project... (it's been 14mo)