search

lixqopensorce / softart

Automatically exported from code.google.com/p/softart
Other
0 stars 0 forks source link

SystemInfo.cmake does not set GCC_VERSION on UNIX #46

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,

I ported your idea of SystemInfo.cmake to SOCI project
(here is my version 
https://github.com/denisarnaud/soci/blob/master/src/cmake/SociSystemInfo.cmake)
and I notice that GCC_VERSION variable is not set on Unix.

This variable is used in line 58

http://code.google.com/p/softart/source/browse/trunk/sasl/build/cmake/SystemInfo
.cmake?r=368#58

but GCC is queried for version only for MinGW in line 40:

http://code.google.com/p/softart/source/browse/trunk/sasl/build/cmake/SystemInfo
.cmake?r=368#40

Simply, it only needs to move the exec_program from if(MINGW) somewhere at the 
top of the script and change the condition to if(MINGW OR UNIX).

Also, this

... "gcc-"${GCC_VERSION})

should read

"gcc-${GCC_VERSION}")

otherwise there is a space between hyphen and version number.

Thanks for the very nice idea of this script!

Original issue reported on code.google.com by mloskot on 24 Dec 2010 at 1:41

GoogleCodeExporter commented 9 years ago 
Hi, thanks for your report!

Now we did not migrate our code to *NIX, so the platform configuration file are 
not finished. We will fix it in our linux-supported release.

Original comment by wuye9036 on 5 Jan 2011 at 6:10

GoogleCodeExporter commented 9 years ago

Original comment by wuye9036 on 26 Jan 2011 at 5:02

GoogleCodeExporter commented 9 years ago

Original comment by wuye9036 on 26 Jan 2011 at 5:14

GoogleCodeExporter commented 9 years ago

Original comment by wuye9036 on 15 Dec 2011 at 3:24

GoogleCodeExporter commented 9 years ago

Original comment by wuye9036 on 7 Mar 2012 at 3:07

GoogleCodeExporter commented 9 years ago

Original comment by wuye9036 on 20 Sep 2012 at 12:15

GoogleCodeExporter commented 9 years ago

Original comment by wuye9036 on 4 Dec 2012 at 6:35

GoogleCodeExporter commented 9 years ago 
It has been fixed at cl d9ea33bd932f. see #246

Original comment by wuye9036 on 4 Jun 2014 at 11:24