liyofx / dolphin-player

Automatically exported from code.google.com/p/dolphin-player
0 stars 0 forks source link

build error #30

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. clone the latest version of the code.
2. build per instructions
3. observe the error:

jni/jpeg/jidctfst.S: Assembler messages:
jni/jpeg/jidctfst.S:66: Error: missing ')'
jni/jpeg/jidctfst.S:66: Error: garbage following instruction -- `pld (r2,#0)'
jni/jpeg/jidctfst.S:259: Error: missing ')'
jni/jpeg/jidctfst.S:259: Error: garbage following instruction -- `pld (sp,#32)'
jni/jpeg/jidctfst.S:271: Error: missing ')'
jni/jpeg/jidctfst.S:271: Error: garbage following instruction -- `pld (ip,#32)'
make: *** [obj/local/armeabi-v7a/objs/jpeg/jidctfst.o] Error 1

What is the expected output? What do you see instead?

expected a completed build, got the error show above instead.

What version of the product are you using? On what operating system?

Android NDK r8.

Please provide any additional information below.

I was able to fix this problem by changing the paranthesis to brackets on all 
PLD lines :

the PLD lines should read 

PLD     [p1, p2]

and not 

PLD     (p1, p2)

Original issue reported on code.google.com by coderroa...@gmail.com on 7 Mar 2013 at 3:15

GoogleCodeExporter commented 8 years ago
Confirmed.  Here is the diff the compiled for me:

diff --git a/p/jni/jpeg/jidctfst.S b/p/jni/jpeg/jidctfst.S
index 34e1c24..b35f938 100644
--- a/p/jni/jpeg/jidctfst.S
+++ b/p/jni/jpeg/jidctfst.S
@@ -63,7 +63,7 @@

 jpeg_idct_ifast:
-    PLD     (r2, #0)
+    PLD     [r2, #0]
     stmdb   sp!, {r4,r5, r6,r7, r8,r9, r10,r11, r12,lr}
     ldr     r4, [sp, #4*10]
     sub     sp, #local_SIZE
@@ -256,7 +256,7 @@ VLoopHead:

 HLoopStart:
     // reset pointers
-    PLD     (sp, #off_WORKSPACE)
+    PLD     [sp, #off_WORKSPACE]
     add     ip, sp, #off_WORKSPACE
     ldr     r10, local_RANGE_TABLE

@@ -268,7 +268,7 @@ HLoopTail:
     str      r0, local_OUTPUT_BUF
     add      fp, r2, r1

-    PLD      (ip, #32)
+    PLD      [ip, #32]
     ldmia    ip!, {r0-r7}

     cmp      r1, #0

Original comment by elje...@gmail.com on 7 Mar 2013 at 11:38