liyunfan1223 / mod-playerbots

AzerothCore Playerbots Module
https://discord.gg/NQm5QShwf9
GNU Affero General Public License v3.0
202 stars 114 forks source link

If item is equipped by bot, put it in enchant slot instead #165

Open doowahree opened 4 months ago

doowahree commented 4 months ago

Describe the solution you'd like If a bot has an item equipped and player asks for it, put it in the enchant slot.

Useful if you're keeping all the oils and enchant professions and need to put stuff on it.

Describe alternatives you've considered Alternative is to have the player give the bot the items and have the bot use it on their items but this is annoying.

Additional context This can be done most likely by TradeAction::Execute so that if the item is equipped, put the slot as TRADE_SLOT_NONTRADED.

Will put a PR in the future.

doowahree commented 4 months ago

Turns out the bot already applies buffs if you give items to it automatically.

But the enchant thing still holds when you're trying to enchant an item that's not soul bound and you have no slots left.

Dreathean commented 4 months ago

Pretty cool idea if you were wanting to toggle off the ability for bots to enchant their items themselves, though I can't see putting myself through that for 24 bots for a 25 man raid team haha. Could see it being useful though if a bot applied a mediocre enchant and you have a better one available.