liyunfan1223 / mod-playerbots

AzerothCore Playerbots Module
https://discord.gg/NQm5QShwf9
GNU Affero General Public License v3.0
280 stars 150 forks source link

Bots doesnt join Alterac Valley as they did before. #443

Closed rogerc66 closed 1 week ago

rogerc66 commented 3 months ago

Describe the bug Bots doesnt line up Alterac Valley as they did before, I'm not sure it's a bug or purposely designed.

Commit hash Latest revision.

To Reproduce Steps to reproduce the behavior:

  1. log in
  2. queue for AV battleground.

Expected behavior Bots should queue for BG as player does.

Screenshots Not necessary.

Desktop (please complete the following information):

Additional context None.

fuzzdeveloper commented 3 months ago

Just tried this myself (definitely on latest commit) and it works fine, are certain that sure NO bots are queuing? You can see whether anyone queues up by looking for messages like this: image Reason I bring that up is that it's possible (depending on number and distribution of bots in your server) that there's not enough bots of your level bracket to get an AV game going (if you use the command playerbot rndbot stats in console you can see a level breakdown of bots on your server)

rogerc66 commented 3 months ago

Screenshot 2024-08-06 at 10 26 21 PM Screenshot 2024-08-06 at 10 27 23 PM looks there is no bots queues after Checking BG queue on my server, is there a min population for them to start queuing? did I missed any key parameter in conf? 屏幕截图 2024-08-07 161853 and why there is only settings for Warsong BG, the others are missing?

fuzzdeveloper commented 3 months ago

Those settings are related to bots queuing without players, you don't need those to have an AV game, AiPlaybot.RandomBotJoinBG = 1 (the first setting in your pic) should be enough.

Those population numbers look like they could be an issue, you need 40 per faction to fill an AV game, not sure how many needed to start but you definitely don't have 40 bots per faction in any bracket. I'd increase the bot count (or set min-max bot levels closer to your own level and reroll them with playerbot rndbot init) and see if that resolves it.

[edit] Actually, taking another look at your settings the AiPlaybot.RandomBotAutoJoinBG setting is likely causing you issues too, as it's making the bots start their own bot only games, which likely leaves you with not enough to join your game (especially considering you don't have enough for a full AV game as it is). I would disable that. So in sum make sure these settings are in place: AiPlayerbot.RandomBotJoinBG = 1 AiPlayerbot.RandomBotAutoJoinBG = 0 (this makes the remaining AiPlayerbot.RandomBotAutoJoinXXX settings in your pic redundant so you don't need need to modify those)

Those settings are the defaults by the way (but you've probably adjusted them trying to resolve this issue), try adjust these settings first, then if that doesn't work, try adjust bot numbers/levels as mentioned above.

rogerc66 commented 3 months ago

I have increased bot number to 900+ and now both fraction has 70+ bots each bracket, but no luck, I will pull a clean version of code and test again, will get back later

fuzzdeveloper commented 3 months ago

Did you try AiPlayerbot.RandomBotAutoJoinBG = 0 like I said?

rogerc66 commented 3 months ago

Did you try AiPlayerbot.RandomBotAutoJoinBG = 0 like I said?

Yes, I found out why it was not working, I have npcbot integrated and mod-solo-lfg, I have disabled npcbot join bg and disabled mod-solo-lfg, now playerbot start to queue bg, before, my npcbot can join bg with playerbot together, now they seems repell each other, I wonder how to make them both join bg without conflict.

CrypticAvocado commented 3 months ago

Those settings are related to bots queuing without players, you don't need those to have an AV game, AiPlaybot.RandomBotJoinBG = 1 (the first setting in your pic) should be enough.

Those population numbers look like they could be an issue, you need 40 per faction to fill an AV game, not sure how many needed to start but you definitely don't have 40 bots per faction in any bracket. I'd increase the bot count (or set min-max bot levels closer to your own level and reroll them with playerbot rndbot init) and see if that resolves it.

[edit] Actually, taking another look at your settings the AiPlaybot.RandomBotAutoJoinBG setting is likely causing you issues too, as it's making the bots start their own bot only games, which likely leaves you with not enough to join your game (especially considering you don't have enough for a full AV game as it is). I would disable that. So in sum make sure these settings are in place: AiPlayerbot.RandomBotJoinBG = 1 AiPlayerbot.RandomBotAutoJoinBG = 0 (this makes the remaining AiPlayerbot.RandomBotAutoJoinXXX settings in your pic redundant so you don't need need to modify those)

Those settings are the defaults by the way (but you've probably adjusted them trying to resolve this issue), try adjust these settings first, then if that doesn't work, try adjust bot numbers/levels as mentioned above.

If AiPlaybot.RandomBotAutoJoinBG was enabled, I would still expect no bots to be auto joining WSG/Arena based on the count configurations (@rogerc66 has 0 listed for everything)

I thought it could possibly have been a performance issue, since bots won't queue if latency/diff is high.

I have no idea how npcbot Integrated works, but it could be for a whole bunch of things such as bots being in combat, bots somehow being queued for an unrelated BG that never pops (only one queue allowed at a time) etc

You may need to do some playing around with npcbots integrated enabled to try figure out what state the bots are in that could be causing them not to queue when a player queues. (Are the bots you are using even 'playerbots'?)

rogerc66 commented 3 months ago

Those settings are related to bots queuing without players, you don't need those to have an AV game, AiPlaybot.RandomBotJoinBG = 1 (the first setting in your pic) should be enough. Those population numbers look like they could be an issue, you need 40 per faction to fill an AV game, not sure how many needed to start but you definitely don't have 40 bots per faction in any bracket. I'd increase the bot count (or set min-max bot levels closer to your own level and reroll them with playerbot rndbot init) and see if that resolves it. [edit] Actually, taking another look at your settings the AiPlaybot.RandomBotAutoJoinBG setting is likely causing you issues too, as it's making the bots start their own bot only games, which likely leaves you with not enough to join your game (especially considering you don't have enough for a full AV game as it is). I would disable that. So in sum make sure these settings are in place: AiPlayerbot.RandomBotJoinBG = 1 AiPlayerbot.RandomBotAutoJoinBG = 0 (this makes the remaining AiPlayerbot.RandomBotAutoJoinXXX settings in your pic redundant so you don't need need to modify those) Those settings are the defaults by the way (but you've probably adjusted them trying to resolve this issue), try adjust these settings first, then if that doesn't work, try adjust bot numbers/levels as mentioned above.

If AiPlaybot.RandomBotAutoJoinBG was enabled, I would still expect no bots to be auto joining WSG/Arena based on the count configurations (@rogerc66 has 0 listed for everything)

I thought it could possibly have been a performance issue, since bots won't queue if latency/diff is high.

I have no idea how npcbot Integrated works, but it could be for a whole bunch of things such as bots being in combat, bots somehow being queued for an unrelated BG that never pops (only one queue allowed at a time) etc

You may need to do some playing around with npcbots integrated enabled to try figure out what state the bots are in that could be causing them not to queue when a player queues. (Are the bots you are using even 'playerbots'?)

Thank you! I figured it out, I just have to wait a few second for playerbots to line up and then they will join bg with npcbot, 2 type of bots has different stategy and pathing, make bg more complex and more fun to watch them fight.

Easy to tell the difference of 2 bots, playerbot are lvl80 and npcbot are lvl70, and they behave differently as well.

屏幕截图 2024-08-10 055952 屏幕截图 2024-08-09 232530 屏幕截图 2024-08-09 232335 屏幕截图 2024-08-09 232515 屏幕截图 2024-08-09 232734

ToneCre8 commented 3 months ago

Sorry to ask this here, but you've had success running NPCBots together with Playerbots? What were the hurdles?

rogerc66 commented 3 months ago

What were the hurdles?

Yeah, not much, just merge a few conflict files and compile them, carefully mock with conf setting, and it will run, so that you can bring your pet bot into playerbot bg having lots of fun.

There are actually 4 kind of bots, playerbots, your hired npcbot (body guards), npc-wandering-bot self act like playerbot, and my own eluna spawn bots.

fuzzdeveloper commented 3 months ago

I thought it could possibly have been a performance issue, since bots won't queue if latency/diff is high.

That' only happens if you use enablePrototypePerformanceDiff (which isnt the default)

hermensbas commented 1 week ago

I thought it could possibly have been a performance issue, since bots won't queue if latency/diff is high.

That' only happens if you use enablePrototypePerformanceDiff (which isnt the default)

Indeed that was the cause with that enabled they only join if ping is low. These feature has been removed entirely for now for different reasons.