liyunfan1223 / mod-playerbots

AzerothCore Playerbots Module
https://discord.gg/NQm5QShwf9
GNU Affero General Public License v3.0
238 stars 132 forks source link

Crash - SearchForBestPath #478

Open serverwar opened 1 month ago

serverwar commented 1 month ago

1cc4836d8210+worldserver.exe[14-8_16-59-4].txt I worked hard to identify this error, I put extra log to catch error at the right point, and I saw that the SearchForBestPath function is receiving null value for x and y, after receiving the null value the server crashed server.log last information. @liyunfan1223

image

serverwar commented 1 month ago

A new crash after updates 1cc4836d8210+worldserver.exe[14-8_18-58-58].txt

noisiver commented 1 month ago

Looks like a crash caused by ChatReplyAction. Maybe @atidot3 knows why this is happening and can or is possibly already working on a fix?

Always disabling chat myself I hope I don't run into this

atidot3 commented 1 month ago

Hmmm where do you see its from charreplyaction ? PlayerbotAI.cpp line 1067 seems related to knockback : bot->GetMotionMaster()->MoveKnockbackFromForPlayer(bot->GetPositionX() + vcos, bot->GetPositionY() + vsin, horizontalSpeed, verticalSpeed);

Ok i didnt saw the second post .... Its a HEAP issue way too much allocation thats what im working on with the optimization pr

noisiver commented 1 month ago

I was just about to mention the second crash report. I figured you were working on something for this, I seem to remember something being mentioned on Discord.

I guess disabling chat would stop it from crashing until you're done with that PR? We don't want you to rush it out just to deal with that crash.

atidot3 commented 1 month ago

Thing is it depends on people computers, with small amount of bots or high etc, its a complicated one as HEAP is allocation on the stack witch occures everywhere

noisiver commented 1 month ago

Yes but to clarify, if people are having crashes from this - would disabling chat stop it from crashing until it's been sorted out? It's good to know what to tell people (even though it's a temporary thing) if people start asking about crashes like this one.

atidot3 commented 1 month ago

It should help for sure to disable it

serverwar commented 3 weeks ago

1cc4836d8210+worldserver.exe[19-8_2-38-22].txt New crash @liyunfan1223

serverwar commented 3 weeks ago

f357e051decc+worldserver.exe[23-8_13-17-50].txt Hey, is it okay if you can pay attention to this error? @liyunfan1223

serverwar commented 2 weeks ago

1cc4836d8210+worldserver.exe[24-8_19-57-58].txt There is more space in this part, I got it right and the crash stopped. https://prnt.sc/wApOdWsmbMWz

liyunfan1223 commented 2 weeks ago

1cc4836d8210+worldserver.exe[19-8_2-38-22].txt New crash @liyunfan1223

Fixed. https://github.com/liyunfan1223/mod-playerbots/pull/491

liyunfan1223 commented 2 weeks ago

f357e051decc+worldserver.exe[23-8_13-17-50].txt Hey, is it okay if you can pay attention to this error? @liyunfan1223

Might be fixed but not sure. https://github.com/liyunfan1223/mod-playerbots/pull/491

serverwar commented 2 weeks ago

f357e051decc+worldserver.exe[25-8_11-16-27].txt - New crash @liyunfan1223 Friend, thank you very much for your commitment to help, great work

serverwar commented 2 weeks ago

After updating, there are only 2 crashes that register in my logs, the second one is the one that gets in the way the most. 9dbe5070ebea+worldserver.exe[29-8_22-34-0].txt -1

9dbe5070ebea+worldserver.exe[29-8_19-58-7].txt -2 @liyunfan1223

Another problem is that sometimes the bot generates a delay, I had to create some lua scripts, to make the bot go to Dalaran every 1 hour, it seems that something happens to them and the server freezes every 5 minutes.

noisiver commented 1 week ago

I'm not super surprised you're having certain issues if you're using Eluna with Playerbots.

serverwar commented 1 week ago

I'm not super surprised you're having certain issues if you're using Eluna with Playerbots.

I have a lot of players exploring it, errors happen without it, because I already took it out to test

serverwar commented 1 week ago

9dbe5070ebea+worldserver.exe[31-8_11-14-34].txt @liyunfan1223 Hey, how are you? The mistakes I'm pointing out to you are the most critical ones, which are getting in my way.

serverwar commented 1 week ago

9dbe5070ebea+worldserver.exe[1-9_1-49-7].txt - @liyunfan1223

serverwar commented 1 week ago

9dbe5070ebea+worldserver.exe[1-9_1-49-7].txt - @liyunfan1223

Can you help me with this crash?

liyunfan1223 commented 1 week ago

https://github.com/liyunfan1223/mod-playerbots/commit/87978d6cd8f6b01c2aea9345484054bead1365d1 I hope they are fixed now. Just curious, how do you run the server? Some of the crash conditions seem pretty rare to me.

serverwar commented 1 week ago

87978d6 I hope they are fixed now. Just curious, how do you run the server? Some of the crash conditions seem pretty rare to me.

My server is on a dedicated 128gb ram 40 cores, windows 2022 server, I only use customization in eluna engine but there are very few, crossfaction module, ahbot, transmog and 1x1.

Server stays online for about 7 hours, then sometimes it goes down twice in a row.

There are errors like this that rarely happen 8155c0e16088+worldserver.exe[6-9_18-55-24].txt

serverwar commented 4 days ago

Updated today, let's see how it goes, thanks again -------------------

serverwar commented 3 days ago

@liyunfan1223 2 days without any crash, one question is sometimes the server freezes for 5 seconds and comes back, or the update goes up for a long time online generating a 1 second delay, is there anything I can do to monitor what is generating these high loads.

serverwar commented 2 days ago

ad42ec6c5583worldserver.exe[11-9_21-37-6].txt ad42ec6c5583worldserver.exe[11-9_12-18-0].txt It's much more stable, today 2 new crashes appeared, after 2 days without anything @liyunfan1223

serverwar commented 1 day ago

@liyunfan1223 2 days without any crash, one question is sometimes the server freezes for 5 seconds and comes back, or the update goes up for a long time online generating a 1 second delay, is there anything I can do to monitor what is generating these high loads.

image

serverwar commented 1 day ago

ad42ec6c5583worldserver.exe[12-9_22-16-7].txt @liyunfan1223 If you can look at these 3 crash logs, it helps me a lot, it's 1 different per day, eliminating it will be 1000%