search

liyunfan1223 / mod-playerbots

AzerothCore Playerbots Module
https://discord.gg/NQm5QShwf9
GNU Affero General Public License v3.0
283 stars 151 forks source link

Account name can block summon alts of same name. #643

Open JakalairVG opened 2 weeks ago

JakalairVG commented 2 weeks ago

Describe the bug If the an account name and player name are the same it can cause problems summoning the bot as an alt.

Commit hash 2e37c1ff1d7fb36d5a003edc44a15a939a2d4667

To Reproduce Steps to reproduce the behavior:

  1. create 2 accounts one named "george" and the other "tarzan", neither of them GM accounts. (any names work)
  2. on account "george" create two characters named "jane" and "tarzan"
  3. login on jane and attempt to use the command ".playerbots bot add tarzan" and it will not work.
  4. log out of jane and into tarzan and try to summon jane ".playerbots bot add jane" and it will work.

Expected behavior It should check and see the account that is not accessible and then check the player after. Thus even if there is an account and player with the same name it will not conflict with each other. Either that or a way to specify that I want to add an account or a player.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context I stumbled across this while setting up the server and for some reason I could never summon in one character. Turns out I had named the GM account the same name as that character not thinking about it. I did some more testing just to see if it was unbot, but even the console command was not doing anything.

Bobblybook commented 2 weeks ago

Confirmed, I had a similar issue - character name the same as acct name and I had no way to reference the character only, it would invite the whole acct at once and form a raid.

I had no solution currently and had to rename my account to something else, but something does need to implemented to be able to explicitly specify acct or char.