search

liyunfan1223 / mod-playerbots

AzerothCore Playerbots Module
https://discord.gg/NQm5QShwf9
GNU Affero General Public License v3.0
289 stars 158 forks source link

Revert "disabled smartscale by default for now (#663)" #683

Closed hermensbas closed 2 weeks ago

hermensbas commented 2 weeks ago

Enables smartscale as default again, can be applied when proven/tested the current scaling is doing his job as intended.

I've run every possible test i can think of literally 100's of build and variants of config setups. But let the community decide, or atleast the owner.

liyunfan1223 commented 2 weeks ago

My personal idea is that we can disable this feature by default, and if users do encounter performance problems, guide them through this configuration to solve the issue.

hermensbas commented 2 weeks ago

Ye was kinda having doubts either direction. Sounds like a good idea. I will close the the PR

hermensbas commented 2 weeks ago

Additionally the original scaling is not working as one would expect. It those work as in keep resources free for more important situations. But the percentages pf botAloneActive when lower then 100 will make bots go active and inactive in matter of seconds.

I feel more for rewrite the whole part into default with 100% and another option who simple keeps the bots idle when nobody is around or not being attacked.

When i have time i will verify what the behaviour is in the cmangos branches.

For now the autoscale works pretty good in combination with higher updateInterval. So i am not touching this for long while. I might experiment locally abit more.

What i did notice is that 4k about max, anything beyond the code and core has troubles with the number of interations, even when they not allowed to move.