Characters are not marked as offline

[d-christ]

Describe the bug When a player logs out the character is still marked as online (In the "characters" table, the value "online" is not updated to "0". it stays at "1". This is only resetted if the server is restarted

Commit hash abd9b4ebb862354dbfce18fbe857bf61932aca8d

To Reproduce Steps to reproduce the behavior:

1. Log in
2. Log out 3 Look at "characters"-Table for the character just logged in. "Online" should be "0", but is "1"

Expected behavior "characters"."Online" should be "0" when character is logged off

Additional context AC> AzerothCore rev. unknown 1970-01-01 00:00:00 +0000 (Archived branch) (Unix, Release, Static) Connected players: 0. Characters in world: 1369. Connection peak: 1. Server uptime: 12 hour(s) 47 minute(s) 45 second(s) Update time diff: 10ms. Last 500 diffs summary: |- Mean: 13ms |- Median: 11ms |- Percentiles (95, 99, max): 26ms, 30ms, 32ms Using SSL version: OpenSSL 3.0.2 15 Mar 2022 (library: OpenSSL 3.0.2 15 Mar 2022) Using Boost version: 1.74.0 Using CMake version: 3.22.1 Using MySQL version: 80040 Found MySQL Executable: /usr/bin/mysql Compiled on: Linux 5.15.0-125-generic Worldserver listening connections on port %u Realmlist (Realm Id: 1) configured in port 8085 VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true MMAPs status: Enabled maps directory located in /home/azerothcore/azerothcore-wotlk/data/maps. Total size: 291014951 bytes vmaps directory located in /home/azerothcore/azerothcore-wotlk/data/vmaps. Total size: 658130721 bytes mmaps directory located in /home/azerothcore/azerothcore-wotlk/data/mmaps. Total size: 2192910844 bytes Default DBC locale: enUS. All available DBC locales: enUS Using World DB: ACDB 335.12-dev Using Playerbots DB Revision: Latest LoginDatabase update: 2024_01_20_00.sql Latest CharacterDatabase update: playerbots_names.sql Latest WorldDatabase update: world_playerbots_rpg_races.sql LoginDatabase queue size: 0 CharacterDatabase queue size: 0 WorldDatabase queue size: 0 PlayerbotsDatabase queue size: 0 List of enabled modules: |- mod-ah-bot |- mod-aoe-loot |- mod-breaking-news-override |- mod-eluna |- mod-guildhouse |- mod-playerbots |- mod-transmog

[noisiver]

This isn't specific to playerbots. The core has this issue to begin with.

[Dreathean]

I saw he posted this issue originally on the core, and they closed it immediately when they saw he had playerbots module, saying it must be a playerbots only issue. https://github.com/azerothcore/azerothcore-wotlk/issues/20545

Though admittedly the person that reviewed it did say they couldn't replicate the issue on base core.

[noisiver]

Well, I know there is no code in the core that marks a character as offline (online = 0) when they log out. It only ever does this on startup. I know this for sure. There is even a PR draft open to address this in the azerothcore repo.

[d-christ]

I didnt test it on a clean Installation, but i think i will do that and then try to reisen the Ticket.

If there is a PR i maybe just merge that into my local code...

Thanks for the hint. And @Dreathean: thanks for your comment. Highly appreciated!

[d-christ]

Closed as it seams to be a core-problem

[noisiver]

I actually ran tests on stock AC. I can't replicate it anymore. It was an issue before but I can't get it to happen anymore no matter what I do. I don't know if this is core-side playerbots or the module but it isn't azerothcore itself.

[d-christ]

We tried it on an installation with playerbots and ah-bot only.

[d-christ]

This is the pull-Request: https://github.com/azerothcore/azerothcore-wotlk/pull/20367

Could we use this on the playerbot-branch?

[zbhcn]

I actually ran tests on stock AC. I can't replicate it anymore. It was an issue before but I can't get it to happen anymore no matter what I do. I don't know if this is core-side playerbots or the module but it isn't azerothcore itself.

Yes, it isn't azerothcore itself core-problem. it's playerbots only

[hermensbas]

As @zbhcn stated

[d-christ]

@hermensbas : ehrm... @zbhcn stated that this is a playerbots problem. Why did you close the ticket?

Little update from my personal installation: i tried the "fix" from the fork manually. It didnt work. Everyone is still marked online from the first login.

[noisiver]

I don't know if it's an issue on the core side or the module but it is indeed an issue with playerbots and not stock azerothcore.

[zbhcn]

i tried the "fix" from the fork manually. It didnt work too, So this fix fork doesn't solve this problem at all

[hermensbas]

ow haha mistake