liyunfan1223 / mod-playerbots

AzerothCore Playerbots Module
https://discord.gg/NQm5QShwf9
GNU Affero General Public License v3.0
289 stars 158 forks source link

Allows the player to use a random bot as ATM #717

Closed mw108 closed 1 week ago

mw108 commented 1 week ago

Attempt to fix the issue that random bots refuse to just give the player money in a trade session.

mw108 commented 1 week ago

image

image

Dreathean commented 1 week ago

Curious what other people think but I would imagine this should at the least be a config option to toggle, I don't expect too many people to want this for their servers as the default option. It's not a bug/issue but a design choice as is.

noisiver commented 1 week ago

This shouldn't be the default behavior, no. It's open to abuse since the random bots will be given random amount of gold. That would essentially be an endless supply of gold.

Configurable sounds like a reasonable thing if a thing like this is to be implemented.

PaoloBenigni commented 1 week ago

I don't think this makes sense to implement. If you have a server where you play solo and want to give yourself money there are ways to do that without bot farming. If you have multiple players then this makes less sense to enable.

mw108 commented 1 week ago

In the Wiki there was no clear description that trading gold to a player is meant for altbots only. Therefore I assumed that this is a bug. But I understand the issue here. I agree that this shouldn't be the default behavior and configurable.

A scenario, where receiving gold from bots is desired, would be a server like SoloCraft where the aim is to clear the content mainly solo with the help of bots and where economy doesn't really matter.

PaoloBenigni commented 1 week ago

Maybe the cmangos implementation documentation mentioned it.

Instead of farming bots why not just gm add a bunch of money?

mw108 commented 1 week ago

Yes, GM command to give you gold works for players with GM capabilities. I imagine a scenario for players without GM rights.

Dreathean commented 1 week ago

We could certainly update the wiki to make it clear that it's intended for use with altbots specifically

hermensbas commented 1 week ago

Why should this be a feature of bots? Providing players with gold? Sure there is trade function which can be abused, but that isnt the intend. I personally rather dont see configuration options or features like this with all respect.

liyunfan1223 commented 1 week ago

Agree with others, this shouldn't be the default behavior, but it's ok if you change it to a configurable option.

noisiver commented 1 week ago

I don't think that's a good name for it.

You're allowing them to trade you gold, it's not a machine you go up to and insert your card into. ๐Ÿ˜†

mw108 commented 1 week ago

You're allowing them to trade you gold, it's not a machine you go up to and insert your card into. ๐Ÿ˜†

I think that you can withdraw cash from an ATM with your card is a relict that will perish eventually and be replaced by biometrics or a chip implant or whatever. If cash still exists then. ๐Ÿ˜ƒ Also, in the end ATM is just an abbreviation. Its function is that you can go to an ATM and withdraw cash from it.

noisiver commented 1 week ago

I still think it's a bad name for it. I guess @hermensbas and @liyunfan1223 are best at making that judgement so hopefully they can chime in.

mw108 commented 1 week ago

I've added an option to the config file which is disabled by default.

I'd like to apologize seeing the controversy this implementation sparked. It wasn't my intention to just implement a useless feature.

As I said, I was under the impression that this was a bug which was meant to work correctly due to the missing statement in the Wiki that trading gold to players is only meant for altbots.

You are - of course - not required to merge this PR. I think it is a nice addition though I would like to have for my server.

noisiver commented 1 week ago

It's optional and disabled by default so I don't see why it shouldn't be merged.

PaoloBenigni commented 1 week ago

I don't understand why it's a good thing to add this. I don't buy the logic of implementing a feature, even if disabled by default, that doesn't align with RnD bits, which as supposed to simulate other players.

Is farming bots for gold a reasonable feature to add? I can't see how this is a good thing in either solo or group play. It's easy enough to give a player a ton of gold without this.

noisiver commented 1 week ago

I don't understand why it's a good thing to add at all. I don't buy the logic of implementing a feature, even if disabled by default, if it doesn't add to the game.

Is farming bots for gold a reasonable feature to add? I can't see how this is a good thing in either solo or group play. It's easy enough to give a player a ton of gold without this.

These points are the equipment equivalent of this but it's there still. A player also can't give themselves gold if they don't have access to the command.

This feature is not something I'd use myself, though I use other means of farming gold which could easily be replaced by GM commands, but if someone wants it it's there.

It's up to the other contributors to make the decision on wheather or not to merge this.

hermensbas commented 1 week ago

True but... : :)

While ATM functionality is basically a proxy cheat through the bots, it doesnt involve bots. If someone wants a gold cheat then either GM command it or make a module for it so none-GM player can spawn gold. But using playerbots as proxy cheat seems wrong imo.

Surely we can add it by using with a config option but in that extend where to we draw the line? In my honost opinion this should not be merged with all respect.

mw108 commented 1 week ago

Is farming bots for gold a reasonable feature to add? I can't see how this is a good thing in either solo or group play. It's easy enough to give a player a ton of gold without this.

I think you're maybe overthinking it a bit too much. I mean you are completely right from the perspective of a public live server with many players and a player driven economy. Such a feature would be catastrophic. But from what I've seen there is no live WotLK private server that even runs mod-playerbots, which I don't understand honestly. There should be demand for it, don't you think? All I see are recommendations for SPP (Single Player Repacks).

Gold shouldn't be put too much weight on. I'm playing on a Vanilla server called "SoloCraft". It features bots you can add to your party or raid and play through the content on your own or with friends / guild mates. It is actually quite fun and the server nicely populated.

During leveling you always have a gold issue to buy skills and spells from class or profession trainers, especially when you can learn all trade skills, not only 2. So people always ask around if somebody can send them some gold.

Once you hit raids, gold becomes completely obsolete. Because you can clear the raids with your bots, kick them from the party after each boss and loot 100-200g from the boss and then simply reinvite the bots and continue the raid. This means, during leveling you always have a personal gold scarcity and when you are 60 gold has no meaning anymore.

And it is not about farming bots for gold or change the game settings in a ways that will give you absurd amounts of gold. It is just about having gold on demand when you need it, for training skills and spells. At least that's what I'd like use to that ATM feature for.

Dreathean commented 1 week ago

I guess for my two cents, first I want to say that I appreciate anyone that takes the time to develop anything for this project, so thank you for what youโ€™ve done. However I do agree with the others that there are already many options in place to freely give people gold and I donโ€™t personally see the benefit of adding the option to take from all rndbots which are necessarily given unlimited gold.

Yes you can always add the config like you have, but I guess there becomes the concern with bloat on a conf that is already quite large.

The two main options that already exist are 1) increase gold drop rate in worldserver conf and 2) congratsonlevel module which you can adjust gold given to players based on level (ie 10 gold given for reaching level 20).

hermensbas commented 1 week ago

@mw108 would you hate us if we decline the merge?

PaoloBenigni commented 1 week ago

I do like adding in a response to the attempt to trade gold without anything.

mw108 commented 1 week ago

@mw108 would you hate us if we decline the merge?

No, of course not. ๐Ÿ˜Š

I do like adding in a response to the attempt to trade gold without anything.

There is a response. It says There are no items to trade

hermensbas commented 1 week ago

We all ppl working and spending our precious spare time on this kinda things and we absolutely dont wanna discourage anyone. Maybe we can discuss these type of changes on beforehand when in doubt. We have a discord with a development channel :)