search

liyuntao / kong-init

Declarative configuration tool for Kong
Apache License 2.0
38 stars 8 forks source link

plugins set as "global" are not modifiable #7

Closed ghost closed 6 years ago

ghost commented 6 years ago

plugins set as "global" are not modifiable.

create one...

plugins:
  - name: rate-limiting
    target: global
    enabled: true
    config:
      minute: 101

now go run the kong-init binary and then httpie http://localhost:8001/plugins

then modify it...

plugins:
  - name: rate-limiting
    target: global
    enabled: false <====== changed this
    config:
      minute: 101

now go run the kong-init binary and then httpie http://localhost:8001/plugins

you will see that it is still enabled: true in Kong.

I cannot delete them too

Kong 0.14.1, postgres

liyuntao commented 6 years ago

Thanks for the detailed report here! It seems that there is a logical missing here(clear all existed global plugin before init action).

Will fix it soon.

liyuntao commented 6 years ago

Just pre-released a version v0.8.0-beta-3. It will clear all plugins(not only global plugin) before doing initialization.

Any feedback is welcome.

ghost commented 6 years ago

it works thanks for fix 👍