search

lizachan / simile-widgets

Automatically exported from code.google.com/p/simile-widgets
0 stars 0 forks source link

EXHIBIT: Slider facet histogram broken in Strict Standards compat mode in Gecko #283

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If you're tweaking your page to be in strict standards compat mode in
Gecko, the slider facet histogram is broken.

The culprits are

 if(histogram) {
  this._dom.histogram.style.height = this._dom.bar.offsetHeight;
  this._dom.histogram.style.width = this._dom.bar.offsetWidth;
 }

in slider.js:55 ff.

They should set the style.foo to offset... +'px', then it works for me.

Tested on both Gecko 1.9.0 and 1.9.1.

Original issue reported on code.google.com by l10n....@gmail.com on 22 May 2009 at 2:19

GoogleCodeExporter commented 9 years ago 
assuming that this very simple fix solves the problem, could someone please 
commit
this patch?

thanks a lot!

Original comment by walter.j...@gmail.com on 3 Nov 2009 at 3:38

GoogleCodeExporter commented 9 years ago 
here is a patch for slider.js which i checked-out from
http://simile-widgets.googlecode.com/svn/exhibit/tags/2.2.0/src/webapp/api/scrip
ts/ui/facets

you someone please commit, or shortly explain, what i have to consider when i 
commit.

thx!

Original comment by walter.j...@gmail.com on 3 Nov 2009 at 4:11

Attachments:

GoogleCodeExporter commented 9 years ago 
I just committed the patch.

Original comment by leibo...@mit.edu on 7 Apr 2010 at 2:13