search

lizardmedia / product-attachments-magento2

Magento2 module for adding downloadable product attachments
MIT License
40 stars 37 forks source link

Update composer.json #12

Closed younes0 closed 4 years ago

bartoszkubicki commented 4 years ago

Thank you for your effort! Plese see my comment in code. Have yout tested extension on php 7.2?

younes0 commented 4 years ago

Yes i've tested the module in PHP 7.2 and magento 2.3.3 (uploading via admin and getting attached file via repository)

younes0 commented 4 years ago

Is it good for you @bartoszkubicki or do I need to make changes ? thanks.

bartoszkubicki commented 4 years ago

@younes0 if it is not a problem modify your commit. If you can't do it please let me know and I will do it as separate PR.

younes0 commented 4 years ago

@bartoszkubicki commit is now better I think: supporting php 7.1.X && php 7.2.X

bartoszkubicki commented 4 years ago

@younes0 thank you very much for your contribution.

younes0 commented 4 years ago

Thank you!