lizardqueenlexi / orbstation

The official repository of the Orbstation SS13 server, a fork of /tg/station.
https://www.orbstation.space/
GNU Affero General Public License v3.0
7 stars 18 forks source link

You cannot breed crew plushies (+plush/vending rewrites). #561

Closed lizardqueenlexi closed 1 year ago

lizardqueenlexi commented 1 year ago

About The Pull Request

This PR mainly performs various cleanup and reorganization to plushie code. Namely, all plushies depicting crew members are now subtypes of a special "crew plushie". This makes some icon things easier, and also, disables the breeding mechanic for plushies of actual Orbstation characters. I've also made a few stylistic changes to plushies, slightly editing some descriptions and capitalizing the names of crew member plushies.

In addition, this PR organizes our vending code a little better. The main vending file is retitled _vendors.dm to place it at the top of the folder, and it no longer contains any items. A new file, dept_wardrobes.dm, has been added as a place to hold all items added to departmental wardrobes. The ClothesMate and AutoDrobe remain in the clothing.dm file, to draw a better line between "clothing items anyone can get" and "departmental items".

Why It's Good For The Game

If you try to breed plushies depicting your co-workers, you will probably get fired from your job. (We simply did not remember that this mechanic exists when adding crew member plushies).

The organization side of this PR should be generally beneficial, making it easier to find where to place new items into vending machines while keeping item lists out of the file with functional code.

Changelog

:cl: fix: blacklisted crew member plushies from the breeding mechanic imageadd: added a special icon for the (unobtainable) abstract crew member plushie spellcheck: fixed up a few item name/descriptions code: added a supertype for all crew member plushies code: organized vending code better /:cl: