lizardqueenlexi / orbstation

The official repository of the Orbstation SS13 server, a fork of /tg/station.
https://www.orbstation.space/
GNU Affero General Public License v3.0
7 stars 18 forks source link

Makes the .357 Magnum round into a craftable, instead of printable directly at the autolathe. #603

Closed SansSarif closed 1 year ago

SansSarif commented 1 year ago

About The Pull Request

This has a couple of simple things it does but I'm going mad trying to make it:

  1. Remove the ability to print the .357 bullet as it stands from the autolathe, until such time occurs that the balance of the server justifies being able to print so very freely from the autolathe
  2. Permit the player to invest time & effort into acquiring bullets without spending TC, so that shooting more than 14 shots is still possible without spending over 17 TC
  3. Make the .357 a distinct bullet that's more obvious to the viewer and separate from the casings for the 9mm/10mm etc.

Why It's Good For The Game

While on higher population servers, easy access to a ammunition for a gun that can kill several people is an extremely important balancing metric, on a server with an average pull between 13 and 24 and a chronically understaffed security department the ability to print ammo for nothing more than some iron has become a problem. While other suggestions were made about simply removing the revolver wholesale or removing the ability to create bullets at all on station were suggested, the revolver does start to lose it's luster quite considerably when it begins to functionally provide only the ability to remove 2-3 people from living temporarily.

Thus: this suggestion. Rather than trying to alter the revolver itself, or force users of the revolver to resort solely to spending more TC, the hope is that by creating a barrier to accessing rounds cheaply, ammo will become more of a planned exercise and not a quick pitstop in cargo (or a hidden autolathe in maintenance). The requirements for crafting more ammo will be a little harder than say, crafting improvised shotshells, but no so difficult that we will only see more ammo crafted once in a blue moon, like the current situation with shotgun-shells & advanced weapons from sec/science.

In addition! Some really rudimentary spriting has been done, in hopes of creating a distinct bullet type for folks to both immediately recognise and also to clarify between the three states of a .357 bullet: unloaded, loaded, and spent. (The next thing on the chopping block is the speedloaders, as they are, heinously ugly soulful, but that's another job for another time.)

Changelog

:cl: add: Added a new craft for the .357 round. del: Removed the ability to simply print the .357 round. imageadd: added sprites for: an .357 empty case, a live .357 round, and a spent .357 round. /:cl:

SansSarif commented 1 year ago

Pushing this up as a draft because we're tired and also because we're having three (technically four) problems right now:

  1. oh god i can't actually get the .357 round to actually stop being printable without excising it entirely by commenting it out
  2. oh god i cannot get the sprites i made to work in game
  3. jfc the .357 brass insists it's spent but it's a fresh cartridge
  4. vscode keeps randomly deleting half of tgstation.dme and it's making me cry
SansSarif commented 1 year ago

IT'S READY. IT WORKS. WE'RE SO TIRED OF DISCOVERING NEW AND EXCITING WAYS THAT RANDOM SPOTS IN THE CODE ARE DESIGNED AND NOT DOCUMENTED