lizardqueenlexi / orbstation

The official repository of the Orbstation SS13 server, a fork of /tg/station.
https://www.orbstation.space/
GNU Affero General Public License v3.0
7 stars 18 forks source link

Midround rolls don't happen during the shuttle timer. #639

Closed lizardqueenlexi closed 1 year ago

lizardqueenlexi commented 1 year ago

About The Pull Request

This PR makes a slight change to midround rolling - rolls will be cancelled automatically if the shuttle has been called at all, rather than only after the point of no return.

Why It's Good For The Game

It's extremely frustrating to get an antag roll when the round is already essentially over. It leaves you with the choice to either try to speed through it (usually not great for the game), or ignore it (disappointing for the player). Since shuttles are rarely recalled on Orbstation, making rolls stopped during the shuttle call completely should make this less likely. Of course, you could still get a midround seconds before the shuttle call, but there's no real way to stop that.

Changelog

:cl: qol: midrounds won't roll if the shuttle has been called /:cl: