lizardqueenlexi / orbstation

The official repository of the Orbstation SS13 server, a fork of /tg/station.
https://www.orbstation.space/
GNU Affero General Public License v3.0
7 stars 18 forks source link

Adds missing scream sounds. Makes voluntary screaming audible. #640

Closed lizardqueenlexi closed 1 year ago

lizardqueenlexi commented 1 year ago

About The Pull Request

Adds scream sounds for ratfolk, jellypeople, and podpeople. The sounds for ratfolk and jellypeople are taken from Skyrat (and in the former case, modified to be less ear-grating). The sound for podpeople is sampled from the following file, licensed under a Creative Commons 0 license and thus public domain:

https://freesound.org/people/nicoproson/sounds/631406/

Additionally, screaming with the "scream" emote now produces sound, rather than only involuntary screams. This comes with a 5-second cooldown, the same as laughing, to prevent abuse.

Why It's Good For The Game

Screaming is useful as an indicator that something is wrong, and is also funny. With this change, all of our roundstart species have at least one scream sound. Future work may include making scream sounds selectable rather than strictly species-based, but that is not included in this PR.

As for the second change, I think it's funny to be able to audibly scream on command. If this becomes annoying, we can revert this part.

Changelog

:cl: balance: the "scream" emote will now audibly scream, once every 5 seconds sound: new scream sounds for Podpeople, Ratfolk, and Jellypeople /:cl: