Orbpdate 2023 05 25 - Githubissues

lizardqueenlexi commented 1 year ago

This one was kind of a pain in the ass. Thanks for refactoring like eight things this week, tg!

You can now double-click your corpse to orbit it without being put back in it.
Converted lizards, chickens, butterflies, and killer tomatoes to basic mobs.
You can no longer create a bottomless pit in the Tramstation genetics pen.
You can now buckle yourself to gym equipment and use it via an action button.
Space lizard, carp, slime, and snake plushies have been resprited and now support GAGS.
Resprited buttons and maintenance drone dispensers.
Added the legendary toast sandwich. Grus V rejoice!
You can tip over flashed borgs.
New space ruin: Mech Transport Ship.
New negative quirk: Chronic Illness. This quirk inflicts you with an incurable illness that slowly erases you from the timeline, only managed by a medicine you can get from cargo. There's also a new traitor objective to inflict someone else with it, which probably needs an x-card quirk immediately.
The sparring contract now actually works properly.
Jobs that are supposed to have a unique mind trait (clowns, curators, shaft miners) now actually have those traits.
The entire station can no longer be wiped out by trace amounts of tritium in the air.
Plasmamen can use their helmets as internals without needing a mask.
Added test tubes and racks, for all your mad science needs.
Smaller graffiti now uses up less of your spraycan.
You can now repair and replace APC covers.
New elevator music, based on the classic Robocop title theme.
New modular shield generators for engineer enrichment.

Profakos commented 1 year ago

The tramstation issue:

Openspace space's /turf/open/space/openspace/enable_starlight() proc makes the tile under it register to a proc RegisterSignal(below, COMSIG_TURF_CHANGE, PROC_REF(on_below_change), override = TRUE)
This will call on_below_change on the space tile if the tile under it changes
The openspace space tile becomes a non space tile. The tile on the floor below is none the wiser.
The tile below gets replaced when the map template is loaded, calls the proc reference.
The tile above is no longer space. Proc reference is called on something that doesn't exist.

I can not tell why this is only an issue for us at the moment.

Profakos commented 1 year ago

lizardqueenlexi / orbstation