lizardqueenlexi / orbstation

The official repository of the Orbstation SS13 server, a fork of /tg/station.
https://www.orbstation.space/
GNU Affero General Public License v3.0
7 stars 18 forks source link

Orb merge 2023 07 23 #667

Closed Profakos closed 11 months ago

Profakos commented 11 months ago

Issues that cause drafting:

New features, and some of the important fixes:

BIODOME

lizardqueenlexi commented 11 months ago

I've made some adjustments to maintain parity with Skyrat's language code. Human mobs now properly start with their chosen languages now, instead of none at all.

Profakos commented 11 months ago

All that is left is to edit the unit tests so they make sense for us, as in make it expect the spawned human know two languages (galcom and solcom)

lizardqueenlexi commented 11 months ago

All that is left is to edit the unit tests so they make sense for us, as in make it expect the spawned human know two languages (galcom and solcom)

This isn't possible without completely redesigning the test, because it only checks for number of languages, not the specific ones - and it's important to the test that the numbers are different between two different species. Because all of our species have exactly two languages associated, this is a problem.

I guess we could make an "example species" that only has one language in its language holder, as clunky as that would be.

Profakos commented 11 months ago

New species... the Languageman..

lizardqueenlexi commented 11 months ago

I took a simpler tactic and just disabled the problematic unit test. I seriously doubt it will matter for us.