lizardqueenlexi / orbstation

The official repository of the Orbstation SS13 server, a fork of /tg/station.
https://www.orbstation.space/
GNU Affero General Public License v3.0
8 stars 18 forks source link

Undoes most of our windoor changes #715

Closed Profakos closed 7 months ago

Profakos commented 7 months ago

About The Pull Request

Talked with Lex about this.

You can no longer screwdriver open the panel of a windoor while its closed. Removed our code for jaws of life opening windoors: after a recent refactor, jaws of life already do that, so our unique changes of jaws of life interaction was not neccessary. Keeps the health decrease of the windoors.

Amusingly, technically, jaws of lifes do break windoors when you try to crowbar them into a closed state and forget to cancel the do after in time.

The proper solution should have been allow opening the panel while the windoor was open, but not removing the electronics, and adding wires to it, making them hackable.

Why It's Good For The Game

The change to make windoors easier to get through has gone way overboard. You can easily go into any secure area by using a screwdriver and a crowbar. The original PR said we can be trusted, but quite a lot of non antags kept going into places they should not have had. Crowbarring the door also removed all fingerprints from it, as it became a frame.

Changelog

:cl: balance: You can no longer screwdriver open the panel of a windoor while its closed. Jaws of life uses regular door forcing logic on windoors. /:cl: