search

lizconlan / large-hansard-collider

MIT License
0 stars 0 forks source link

No data available message issued without identifying source #15

Closed robertbrook closed 10 years ago

robertbrook commented 10 years ago

Example: "rake scrape_hansard date=2014-02-24" shows the useful material zipping by, but also shows "No data available for this date", without identifying what the expected data type was.

I'm not sure if this message is being shown even when the expected data was found.

I think it's here: https://github.com/lizconlan/large-hansard-collider/blob/master/lib/parser.rb#L125

lizconlan commented 10 years ago

Good point - that was starting to be a problem here as well.

On 24 Feb 2014, at 12:17, Robert Brook notifications@github.com wrote:

Example: "rake scrape_hansard date=2014-02-24" shows the useful material zipping by, but also shows "No data available for this date", without identifying what the expected data type was.

I'm not sure if this message is being shown even when the expected data was found.

I think it's here: https://github.com/lizconlan/large-hansard-collider/blob/master/lib/parser.rb#L125

— Reply to this email directly or view it on GitHub.

robertbrook commented 10 years ago

Um, just thought I should probably have written a spec for that.

robertbrook commented 10 years ago

Rather than a brusque comment.

lizconlan commented 10 years ago

Issues are good. Emails appear on the second screen!

There was already a spec (one of mine), it just wasn't detailed enough.