search

lizhichao / one

A minimalist high-performance php framework that supports the [swoole | php-fpm] environment
Apache License 2.0
884 stars 127 forks source link

Breaking change detected in patch level #23

Closed waghanza closed 3 years ago

waghanza commented 3 years ago

Hi @lizhichao,

I can see that this dependency has been introduce in 2.0.23, but was not in 2.0.22 https://github.com/lizhichao/one/blob/8ab51aec0ce645c1f952b5628e56e800999437cc/composer.json#L22

This mean bcmath is now required. As I have not this extension, this break my CI (hopefully it is not a production).

BTW, I have fixed this in https://github.com/the-benchmarker/web-frameworks/pull/3632

Regards,

lizhichao commented 3 years ago

@waghanza thank you，lizhichao/one-ck is a clickhouse Tcp connector，There is no database operation here, it will not run automatically

waghanza commented 3 years ago

but having it in composer manifest fails (since composer check if ext-bcmath is setup)

lizhichao commented 3 years ago

嗯，确实有这个问题

waghanza commented 3 years ago

嗯，确实有这个问题

Do not understand any Chinese 😄

lizhichao commented 3 years ago

嗯，确实有这个问题

Do not understand any Chinese 😄

You're right. The composer installation will require this extension ext-bcmath if it is not used