search

lizmat / App-Rak

21st century grep / find / ack / ag / rg on steroids
Artistic License 2.0
152 stars 7 forks source link

make all-invalid group extensions noticed #25

Closed mustafaaydn closed 1 year ago

mustafaaydn commented 1 year ago

hi,

before

rak this --extensions=#bad
rak this --extensions=#bad,#another

was detecting but ignoring the unknown group extensions, and performing a search with @known-extensions. This was the case only if all supplied extensions are invalid groups as .map was producing an empty Seq and then failing with the if. That if is now given :) Now it reports the unknown groups, e.g., No extensions known for '#bad #another'. and exits.

lizmat commented 1 year ago

Thanks for the PR. Feels to me it should complain about unknown groups.

Will sleep over it. Thanks for the report!

mustafaaydn commented 1 year ago

oh yes, it does complain & exit. sorry didn't mention that, edited.

lizmat commented 1 year ago

Thanks again!

Your fix did not fix the issue, although the idea was good.

I've now fixed it with https://github.com/lizmat/App-Rak/commit/c26e474cde

mustafaaydn commented 1 year ago

oh :) part of me still thinks given & what you did is equivalent but perhaps yours is more efficient, wouldn't know. But anyway, it's solved; thank you for the package and all!