search

lizmat / App-Raku-Log

Cro application for presenting Raku IRC logs
Artistic License 2.0
3 stars 2 forks source link

Minor improvements #17

Closed ogdenwebb closed 2 years ago

ogdenwebb commented 2 years ago

Fix #14 - now links should use correct color, also I've added underline on hove to distinct them even more Fix #11 - add padding on homepage Fix jumping footer while sidebar toggling

lizmat commented 2 years ago

Thank you for your work! I've just merged it because I mostly cannot tell what changes fix what problem. If you could make separate PR's for fixing different issues in the future, that would be very nice.

lizmat commented 2 years ago

I think it indeed fixes #14. But it does not fix #11 :-(

I don't see any padding fixed on the home page. image

And on a wider view, the channel's one line description is immediately followed by the period info and overview/live links.

image

I think they should be below the channel's one line, like they are now on the live server:

image

ogdenwebb commented 2 years ago

If you could make separate PR's for fixing different issues in the future, that would be very nice.

Yeah, I will do this way next time.

But it does not fix #11 :-(

Oh, got that. I'll push a fix asap.

I think they should be below the channel's one line, like they are now on the live server

Well, I think it would be better to rework homepage a bit, at this moment it looks pretty weird, especially talking about block with channel info before dates, because it has no padding and mobile layout requires more work on it. There's some other task to complete, so prolly I'll work on that later.

lizmat commented 2 years ago

@ogdenwebb: thank you in advance! :-)