search

lizmat / App-Raku-Log

Cro application for presenting Raku IRC logs
Artistic License 2.0
3 stars 3 forks source link

Rendering a page should not throw any warnings #27

Open lizmat opened 3 years ago

lizmat commented 3 years ago

Apparently, Nil is being rendered in at least a few places in the templates. Sadly, the warnings does not tell where in the template the value came from, which makes fixing a lot harder.

lizmat commented 3 years ago

Confirmed that all of the warning do in fact come from Cro::WebApp.render-template.

lizmat commented 3 years ago

The number of warnings does not seem to be dependent on the number of messages rendered. I've also not been able to find anything common.crotmp that could explain these warnings.

Altai-man commented 3 years ago

This is blocked on https://github.com/croservices/cro-webapp/issues/40 IMO.

lizmat commented 3 years ago

Well, without that being fixed, it is a lot harder to fix this one. But I wouldn't say it's a blocker. I've been able to fix a few already, and put some code in place that will just say "28x Use of Nil in string context" instead of repeating that 28 times on STDERR. :-)

Altai-man commented 3 years ago

But I wouldn't say it's a blocker

IMO fixing it in cro webapp will give an improvement all across the board for all the users, might likely take about the same amount of time as chasing the non-informative version, if one is proficient enough.

lizmat commented 3 years ago

I've looked at the Cro::Webapp code, and I do not see any immediate way to get to the data that we want, apart from somehow changing the way the code is generated (something like generating %foo<bar> as 

{ %foo<bar> // record-failure(%foo, "bar") }

Could you at least give some pointers as what would be a good approach to fix this at the Cro::Webapp level? At the moment, it feels I would spend less time on getting rid of the warnings here, rather than attempting to fix this at the Cro::WebApp level, at least for me.

Altai-man commented 3 years ago

Could you at least give some pointers as what would be a good approach to fix this at the Cro::Webapp level?

Sorry, I did not imply you should fix this. In fact, I looked at fixing it myself yesterday as I had some $dayjob time, but today is an important Comma release for me, so I'm afraid there will be some delay. I myself hope to fix it as soon as possible, so you I recommend to relax and rest or do something more fun instead in the meanwhile. :)