lizrice / learning-ebpf

Learning eBPF, published by O'Reilly - out now! Here's where you'll find a VM config for the examples, and more
https://www.amazon.com/Learning-eBPF-Programming-Observability-Networking/dp/1098135121
Apache License 2.0
1.19k stars 255 forks source link

Instructions on Installing this repo needs a cd command #2

Closed fjsnogueira closed 1 year ago

fjsnogueira commented 1 year ago

Hi,

In the readme of the repo, where it's described how to "Installing this repo", and we have te following steps:

git clone https://github.com/lizrice/learning-ebpf

limactl start ubuntu-ebpf.yaml limactl shell ubuntu-ebpf

cd learning-ebpf

because the ubuntu-ebpf.yaml file comes from the repo, just after cloning the repo the instructions should ask to cd into the cloned repo before the limactl instructions, like this:

git clone https://github.com/lizrice/learning-ebpf

cd learning-ebpf

limactl start ubuntu-ebpf.yaml limactl shell ubuntu-ebpf

Or use the limactl with the path to learning-ebpf/ubuntu-ebpf.yaml

Kind regards, Fernando

fjsnogueira commented 1 year ago

"fixed" in commit 0c1a9009f5e56589dc24ab4b911d511080bb6e27 , although now the readme is now executing cd twice (second is not needed).