Open lizzieinvancouver opened 1 year ago
Perfect, that sounds good! I haven't spent that much time on the figure (gave me the occasion to learn Illustrator). I think I pushed it properly in the repo. Could you please let me know if that is correct? *Also is it ok if I answer here?
@christophe-rd Yes! It's great if you answer as managing git issues is much easier for me than trying to keep track of my inbox.
The figure pushes look good to me. You can check them from clicking on each here; then you can confirm what changed etc.
If you can push png drafts (from Illustrator, file menu then 'export' does this fairly quickly) it would be easier for me.
Thanks!
@christophe-rd Sorry, get lost in figures ... I updated above. For this figure, it looks good! As the focus is supposed to be on the diversity levels (all the lines within Europe), can you crop down the map to northern hemisphere (and fade the edges if easy; google 'fade to transparent illustrator') and make the levels of diversity coming from Europe much bigger then I think this will be close to a good first draft.
Thanks for your help on this!
Perfect, thanks for your comments! I found a way to fade the map to transparent. I pushed it into the repo!
@christophe-rd Looks great! I have a few requests ...
Eventually we should find a less pixelated map (I usually build one in R) but let's wait until we see what co-authors think.
Sorry again for not answering you this week! I need to dedicate additional time to address the faded edges properly. I will keep you updated on my progress.
Hi Lizzie! I worked on the things you requested :
@christophe-rd Thanks!
The way the pedigree works, we should shown the clones coming from a specific variety. So, can you relabel the variety dot that produces the clones as Chardonnay (you could put the name underneath) and relabel the clones as 75 at the start and 1147 at the end?... Wait, this is more confusing to type than to do, so I did it in AI and pushed an update. I hope I did not ruin all your groupings.
Perfect! Sorry again for my late response and thank you for your comments.
For the RX5 ... What I wanted to show is that the roostock ends up on a scion which is one clone of a variety. Maybe for now we can show that by deleting 'RX5 plants' and extend the arrow from SO4 to a clone (and write next to the arrow 'rootstock for vinifera scion'
I pushed back the new version with RX5 deleted. Could you please confirm that this is what you imagined?
If you need me to modify anything else, please let me know!
@christophe-rd Yes, this looks great! I am waiting to hear back from a colleague (will probably be a couple weeks) then should have a better sense of how we want to finalize figures.
@christophe-rd Yes, this looks great! I am waiting to hear back from a colleague (will probably be a couple weeks) then should have a better sense of how we want to finalize figures.
Perfect, thanks for the feedback!
@christophe-rd I haven't been asking for tweaks on this as Andy Walker suggested cutting it, but Iñaki wants to keep it. Unless Thierry feels strongly I think we will keep it, but we can wait to hear from him. However if you're girlfriend has any suggestions on it, that would be most welcome.
@lizzieinvancouver perfect! I will ask her for suggestions and will let you know! Thanks!
@christophe-rd Iñaki was confused on Fig 2 by what Rx5 meant. I confess I cannot recall either, but I am sure we can fix it! Remind me and we can hopefully come up with a way to clarify it.
Hi! I believe it's an older version of the figure that is currently in the ms. Here's the link of the last version
@lizzieinvancouver here's an updated version of the figure with some minor adjustments on the titles. I made all the formats uniform across the 3 different figures.
@christophe-rd Re:
I don't know the convention for refs in a figure. Is it appropriate to add these references here? If so, should we also include them in the references at the end of the paper
Good point! Yes, I can add them to the ref list. If you can find them in Google Scholar then you can save them and export to bibtex and I can import them. Or just send me the full citation info and I can easily do it.
@christophe-rd Can you make the fonts overall larger? I think they are a little hard to read now.
Good point! Yes, I can add them to the ref list. If you can find them in Google Scholar then you can save them and export to bibtex and I can import them. Or just send me the full citation info and I can easily do it.
Perfect, you I created a folder in the figure folder. You can find them both here. I couldn't find the references I mentioned in the figure, but I think the information was still relevant. I changed the articles where the info came from.
@christophe-rd Can you make the fonts overall larger? I think they are a little hard to read now.
Yes, I made the fonts larger! Could you please tell me if it's better now?
@christophe-rd Looks great! Thank you!
Figure 1
I am not 100% sure we will keep this figure so work on it quickly! Minimal time ....
It is supposed to be a map of the northern hemisphere (find a bland creative commons one or make one in R) that fades out at the top and bottom and lists the number of species of Vitis on each continent. Then has something vaguely looking like a coalescent plot (see first figure here) of varieties and clones. There really should be a ... as we cannot show all relationships.
Again, work on this quickly without too much effort.