search

lizzieinvancouver / egret

2 stars 0 forks source link

clean chemical #65

Open lizzieinvancouver opened 3 months ago

lizzieinvancouver commented 3 months ago

@wangxm-forest I think you did most of the chemical cleaning but I am starting an issue as we have some more problems ... from issue #23 @kengi-neer wrote:

However, I did find some of the response values for airi2009 to be mismatched. Some chilling response values were actually KNO3 chemical treatment response values. I did not change them in my script as I think these, along with the previously mentioned cases of response variable and value mismatch, are better cleaned together.

Can you fix this?

Also, spread the word that we should start issues for each column we're cleaning as there is too much in issue #14

kengi-neer commented 3 months ago

@lizzieinvancouver @wangxm-forest Just to add, the indicated treatment is chilling but the response values did not match. I think this might have come about from data scraping because all other details seem to be fine except for the response value.

wangxm-forest commented 3 months ago

@lizzieinvancouver @kengi-neer I have checked the original paper and noticed that some data was entered incorrectly. Should I correct it in the original data scraping file?

lizzieinvancouver commented 2 months ago

@wangxm-forest If you do not think you can/should clean it in R you can check the rules about changing files here ... if you have questions, please ask @DeirdreLoughnan . Thank you!

lizzieinvancouver commented 3 weeks ago

@wangxm-forest will give the code one last look and then close this issue if it looks good!

lizzieinvancouver commented 3 weeks ago

@wangxm-forest double check SS entries (new entries look okay!)

wangxm-forest commented 1 week ago

@ngoj1 Hi Justin. Could you please check the chemical column of the paper "momonoki79" that you scraped? I saw "seed.coat.extract," "stripped.seed.extract," and "stripped.seed extract" listed there, which is a bit unclear to me. I went back to the original paper but couldn't find these as chemical treatments in the figures. Could you provide a bit more detail on this? Thanks!

ngoj1 commented 1 week ago

I saw "seed.coat.extract," "stripped.seed.extract," and "stripped.seed extract" listed there, which is a bit unclear to me

Hi Mao, it's from momonoki79 chapter 6, starting on page 124. The researchers used the seed coat extract of Bupleurum falcatum to look for potential inhibitory effects of some compound on its seeds and then used seeds of lettuce (Lactuca sativa) as their trial study system to determine the inhibitory effect, if any. And then they continue this line of experimentation in chapter 7, where they now test the differences between the two classes of chemical inhibitors they isolated through chromatography.

DeirdreLoughnan commented 1 week ago

@dbuona did this paper by momonoki97 get flagged when you went through and double checked for crops?

I think based on the fact it is on lettuce means it should be excluded from the study.