AileneKane
commented
4 years ago @lizzieinvancouver @dbuona sure! I can do this
Open lizzieinvancouver opened 4 years ago
AileneKane
commented
4 years ago @lizzieinvancouver @dbuona sure! I can do this
dbuona
commented
4 years ago me too!
On Mon, Apr 27, 2020 at 5:24 PM AileneKane notifications@github.com wrote:
@lizzieinvancouver https://github.com/lizzieinvancouver @dbuona https://github.com/dbuona sure! I can do this
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lizzieinvancouver/ospree/issues/370#issuecomment-620242949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJFCYWFU3QLQBIXTJTMXQLROXZXBANCNFSM4MOJWNYQ .
-- Daniel Buonaiuto Dept. of Organismic and Evolutionary Biology Harvard University | Arnold Arboretum
@AileneKane @dbuona Could one of you tidy the notes slightly in clean_misc.R so they more read what you think and thus decided to do, versus sounding a little in-progress. For example:
#d$freeze.treatment.temp_day[d$datasetID=="biasi12"]#this study actually did freeze treatments! but the columns are somehow shifted the values do not make sense for temperatures, mistake?Could be:
#d$freeze.treatment.temp_day[d$datasetID=="biasi12"]#this study actually did freeze treatments! but the columns are somehow shifted such that the values do not make sense for temperatures. We assumed this was a mistake and thus adjust below.And:
#Proposed solution: migrate this column to Field_Chilling_Hours somewhere in chilling code, but ask Ailene?Could be re-written to feel less open-ended ...Thanks!