lizzieinvancouver / ospree

Budbreak review paper database
3 stars 0 forks source link

clean species names again ... #449

Closed lizzieinvancouver closed 1 year ago

lizzieinvancouver commented 1 year ago

@MoralesCastilla caught an error in one species name (Acer seudolatauns). I traced this back to an error in 2019 when we accidentally cleaned up this error in clean_spp_match.R instead of elsewhere in our cleaning scripts (clean_spp_match.R is incredibly slow and we don't always run it).

I fixed this in commit 7c7c361d59540e54e21e0fd69481d9ef326242c1 but I ran into a new issue which is that clean_duplicates.R has gone missing (WTF?).

I also re-ran everything and FYI, you get this error There were 50 or more warnings (use warnings() to see the first 50) ... which I think is okay based on tracing back the error some and looking at the output. Also -- I added this in the notes in clean_spp_match.R :

TPL (the Plant List) is superseded is by World Flora Online ... where some of the unresolved are resolved ... and maybe this is not the IDEAL command for future use (for newer work in the lab, check for newer commands -- actually ... World Flora has a new R package!)

lizzieinvancouver commented 1 year ago

See also issue #450 .... I am closing this issue now. It's fixed.