Make fails when compiling on kernel 3.11

donaghhorgan commented 9 years ago

Hi, I've been trying to build the drivers, but I'm hitting a problem:

Applying patches for kernel 3.11.0-19-generic
patch -s -f -N -p1 -i ../backports/api_version.patch
patch -s -f -N -p1 -i ../backports/pr_fmt.patch
patch -s -f -N -p1 -i ../backports/debug.patch
patch -s -f -N -p1 -i ../backports/drx39xxj.patch
patch -s -f -N -p1 -i ../backports/v3.16_netdev.patch
patch -s -f -N -p1 -i ../backports/v3.16_wait_on_bit.patch
patch -s -f -N -p1 -i ../backports/v3.16_void_gpiochip_remove.patch
patch -s -f -N -p1 -i ../backports/v3.11_dev_groups.patch
2 out of 3 hunks FAILED
make[2]: *** [apply_patches] Error 1
make[2]: Leaving directory `/home/donagh/donagh/media_build/linux'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/donagh/donagh/media_build/v4l'
make: *** [all] Error 2

The problem seems to be with the patch file v3.11_dev_groups.patch. It's supposed to patch v4l2-dev.c, but the patch fails because it's expecting, for instance, a line with debug_show but the corresponding line in the file contains dev_debug_show. Any ideas?

ghost commented 9 years ago

There's not much to work with here but if it helps I encountered a similar issue when running a parallel make which it doesn't like.

Try building with "MAKEOPTS=-j1" or "make -j1" and see if this works for you.

donaghhorgan commented 9 years ago

I tried setting MAKEOPTS to "j1", but it doesn't make any difference. Thanks for the suggestion though.

It looks to me like the patch file is expecting a different version of v4l2-dev.c. For instance, in the version that is supplied with this git repo (media/drivers/media/v4l2-core/v4l2-dev.c), at line 37 I have:

/*
 *  sysfs stuff
 */

static ssize_t index_show(struct device *cd,
              struct device_attribute *attr, char *buf)
{
    struct video_device *vdev = to_video_device(cd);

    return sprintf(buf, "%i\n", vdev->index);
}
static DEVICE_ATTR_RO(index);

static ssize_t dev_debug_show(struct device *cd,
              struct device_attribute *attr, char *buf)
{
    struct video_device *vdev = to_video_device(cd);

    return sprintf(buf, "%i\n", vdev->dev_debug);
}

However, the patch file, which is included in the official V4L media build repo (media_build/backports/v3.11_dev_groups.patch), expects this:

@@ -38,25 +38,24 @@
  *     sysfs stuff
  */

-static ssize_t index_show(struct device *cd,
-                         struct device_attribute *attr, char *buf)
+static ssize_t show_index(struct device *cd,
+                        struct device_attribute *attr, char *buf)
 {
        struct video_device *vdev = to_video_device(cd);

        return sprintf(buf, "%i\n", vdev->index);
 }
-static DEVICE_ATTR_RO(index);

-static ssize_t debug_show(struct device *cd,
-                         struct device_attribute *attr, char *buf)
+static ssize_t show_debug(struct device *cd,
+                        struct device_attribute *attr, char *buf)
 {
        struct video_device *vdev = to_video_device(cd);

        return sprintf(buf, "%i\n", vdev->debug);
 }

Because these are not compatible, applying the patch fails, which appears to be fatal. I have tried disabling the patch by editing the backports.txt file and commenting out the kernel 3.11 section, and this gets me past this point, but then make fails at a later point anyway (presumably because I didn't apply the required patch).

All suggestions are welcome!