ljd3000 / shellinabox

Automatically exported from code.google.com/p/shellinabox
Other
0 stars 0 forks source link

Debian packaging uses cross-directory hardlinks #49

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The install target of the debian/rules file uses ln(1) to link the example CSS 
profiles in 
/usr/share/doc/shellinabox into /etc/shellinabox/options-available/

This makes the package un-buildable within filesystems such as AFS, which don't 
allow cross-
directory hardlinks at all. It also makes the package potentially 
uninstallable, should 
/usr/share/doc/shellinabox and /etc/shellinabox/options-available be on 
different local 
filesystems (which is always at the sysadmins' discretion)

See also <http://lintian.debian.org/tags/package-contains-hardlink.html>

Those files should be either copied between the two locations, or one of the 
locations should be 
a symlink.

Attached is the very straightforward patch to use copies instead of hardlinks.

Original issue reported on code.google.com by evan.broder@gmail.com on 1 Feb 2010 at 10:13

Attachments:

GoogleCodeExporter commented 8 years ago
Same here. Cannot build on sshfs.

Dumb replacement of ln with ln -sf solves the problem.

Original comment by golubov...@gmail.com on 30 Apr 2011 at 1:51

GoogleCodeExporter commented 8 years ago
Furthermore, if you install the links in

   /etc/shellinabox/options-enabled

like that. On every update, links get set again, even if the system 
administrator has decided to remove a link.

You should install the links in a postinst script checking for $2 to see if you 
are on an update or a fresh install.

Regards,
Jan

Original comment by siev...@zedat.fu-berlin.de on 5 Sep 2011 at 2:19

GoogleCodeExporter commented 8 years ago
Compatible patch applied for 2.11.

Original comment by beewoo...@gmail.com on 31 Mar 2012 at 7:41