ljean / modbus-tk

Create Modbus app easily with Python
Other
566 stars 212 forks source link

update expected_length #133

Closed jia-zhengwei closed 2 years ago

jia-zhengwei commented 3 years ago

The code is not tested, just for remind maybe there has a little bug

ljean commented 3 years ago

Hello and thanks for this PR.

Can you pleasde explain why you changed line 161 : expected_length + 2. Why did you add "+2"

Best luc

jia-zhengwei commented 3 years ago

Hello and thanks for this PR.

Can you pleasde explain why you changed line 161 : expected_length + 2. Why did you add "+2"

Best luc

That's my mistake, Yes, it should be expected_length rather than expected_length + 2

ljean commented 3 years ago

Thanks for answer, can you please update your PR with this fix?