search

ljfranklin / terraform-resource

A concourse resource to create infrastructure via Terraform
MIT License
185 stars 85 forks source link

[Feature Request] Install `curl` on images #159

Open simon-swanson-leapyear opened 3 years ago

simon-swanson-leapyear commented 3 years ago

Theoretically this is as easy as adding curl to the apk add ... commands in the Dockerfiles.

curl is a super valuable tool to have available for debugging and execution, as certain Terraform modules assume the tool is available on the system. wget is less common on systems and most tools assume the existence of curl before wget.

For example: wait_for_cluster_command in CloudPosse's EKS cluster module uses curl by default. While this can be overridden to use wget, not all the environments we run Terraform in have wget installed and we would prefer to not introduce a bunch of conditional logic.

Attaching a patch file with how this could look: 0001-Add-curl-to-images.patch.tar.gz

ljfranklin commented 3 years ago

SGTM, please open a PR and I'll be happy to approve.

simon-swanson-leapyear commented 3 years ago

Sorry for the wait, I apparently need to update my email filters.