version around 1.18 breaking CI?

ljharb / es-abstract

ECMAScript spec abstract operations.

MIT License

115 stars 30 forks source link

version around 1.18 breaking CI? #132

Closed lemoustachiste closed 3 years ago

lemoustachiste commented 3 years ago

Hi,

I wasn't able to pinpoint exactly which version breaks CI (with Travis), but reverting a change of this package from 1.18.3 to 1.17.2 fixed my issue.

This was the output before the change:

$ npm ci 

npm ERR! string.prototype.trimend not accessible from es-abstract

Now my build runs as expected. It looks similar to this one: https://github.com/microsoft/azure-pipelines-tasks/issues/14725

ljharb commented 3 years ago

Can you figure out the exact version where this started happening? Also, which version of npm are you using? If npm 7, try updating to v7.20.

zinyosrim commented 3 years ago

I deinstalled node. Reinstalled and now have v14.15.3 I upgraded npm to 7.20.0 Installed es-abstract@1.17.2

The issue is still there when I try to deploy

ljharb commented 3 years ago

Does it also happen on npm 6, or only on npm 7?

zinyosrim commented 3 years ago

Just tried with V.6. Same issue

Jordan Harband @.***> schrieb am Mi. 21. Juli 2021 um 17:33:

Does it also happen on npm 6, or only on npm 7?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ljharb/es-abstract/issues/132#issuecomment-884284596, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHRZF2XZ45R6HTTT52GNB3TY3SENANCNFSM5ATTJPLQ .

ljharb commented 3 years ago

Is there anything in ~/.npmrc or .npmrc besides auth/registry stuff? anything in env | grep -i npm?

isaacs commented 3 years ago

That "not accessible from" error only exists in npm v6. It comes from the npm-logical-tree package. You are using npm v6 in the screenshot. Do you get the same error in npm v7?

The error indicates that you have a package in your tree with a dependency that is not being met. Do you see any errors when you run npm ls?

ljharb commented 3 years ago

@zinyosrim to be specific, try npm 7 in heroku, not just locally.

ljharb commented 3 years ago

Given that this issue only happens in npm 6 and below, and given that very few people have reported it, and given that I can't reproduce it nor do I know what action I could take in es-abstract to fix it - I'm going to close this.

However, if it becomes reproducible for me, or, if someone can come up with something i can change in this package that fixes the problem, I'll be happy to reopen it.

zinyosrim commented 3 years ago

Is there anything in ~/.npmrc or .npmrc besides auth/registry stuff? anything in env | grep -i npm?

zinyosrim commented 3 years ago

After upgrading NPM to latest my deploy succeeded