search

ljharb / es-abstract

ECMAScript spec abstract operations.
MIT License
114 stars 30 forks source link

[New] `ES2021+`: `IterableToList`: make `method` parameter optional #61

Closed ExE-Boss closed 3 years ago

ExE-Boss commented 5 years ago

This makes it possible to call IterableToList without passing method.

Specification:

codecov[bot] commented 4 years ago

Codecov Report

Merging #61 (2ad7fab) into master (59efd18) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files        1130     1130           
  Lines       15575    15577    +2     
  Branches     3457     3458    +1     
=======================================
+ Hits        14870    14872    +2     
  Misses        705      705
Impacted Files Coverage Δ
2021/IterableToList.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59efd18...2ad7fab. Read the comment docs.

ljharb commented 4 years ago

I've rebased this, but it will need test changes as well.

ljharb commented 4 years ago

whoops, this is now basically the same as #68.

Let me see if i can find a way to combine them.

ljharb commented 4 years ago

k, i've pulled in some of the test changes from there.

ljharb commented 4 years ago

I’ll keep both open and in sync when they’re ready to land.

ExE-Boss commented 4 years ago

This branch is meant to be about making the method parameter optional in IterableToList.

ljharb commented 4 years ago

It isn’t optional: https://tc39.es/ecma262/#sec-iterabletolist

ExE-Boss commented 4 years ago

It will be once https://github.com/tc39/ecma262/pull/2040 is merged.