search

ljharb / object.assign

ES6 spec-compliant Object.assign shim. From https://github.com/es-shims/es6-shim
https://tc39.es/ecma262/#sec-object.assign
MIT License
107 stars 22 forks source link

Add test for proving window.location works with Object.assign polyfill #68

Closed JakeChampion closed 5 years ago

JakeChampion commented 5 years ago

It looks to fail the linting because the linter believes window to be undefined.

Should we disable the no-undef rule on each line that use window or should we add window to the globals that are allowed in the file?

ljharb commented 5 years ago

I think an eslint override comment adding it as a global in the test function should work?