search

ljharb / object.assign

ES6 spec-compliant Object.assign shim. From https://github.com/es-shims/es6-shim
https://tc39.es/ecma262/#sec-object.assign
MIT License
107 stars 22 forks source link

Distribution folder was missing during running npm install #83

Closed oburk closed 2 years ago

oburk commented 2 years ago

Hi,

with your last version 4.1.3 you removed the dist folder from the installation.

When I run npm i object.assign@4.1.3 I got:

16.08.2022  09:44    <DIR>          .
16.08.2022  09:44    <DIR>          ..
16.08.2022  09:44    <DIR>          .github
16.08.2022  09:44    <DIR>          test
26.10.1985  10:15               286 .editorconfig
26.10.1985  10:15               627 .eslintrc
26.10.1985  10:15               139 .nycrc
26.10.1985  10:15                36 auto.js
26.10.1985  10:15             8.834 CHANGELOG.md
26.10.1985  10:15             1.618 hasSymbols.js
26.10.1985  10:15             1.414 implementation.js
26.10.1985  10:15               532 index.js
26.10.1985  10:15             1.080 LICENSE
16.08.2022  09:44             3.403 package.json
26.10.1985  10:15             1.299 polyfill.js
26.10.1985  10:15             3.861 README.md
26.10.1985  10:15               305 shim.js
26.10.1985  10:15         1.100.064 test.html

When I run npm i object.assign@4.1.2 I got:

16.08.2022  10:10    <DIR>          .
16.08.2022  10:10    <DIR>          ..
16.08.2022  10:10    <DIR>          .github
16.08.2022  10:10    <DIR>          dist
16.08.2022  10:10    <DIR>          test
26.10.1985  10:15               286 .editorconfig
26.10.1985  10:15                 6 .eslintignore
26.10.1985  10:15               590 .eslintrc
26.10.1985  10:15               232 .nycrc
26.10.1985  10:15                36 auto.js
26.10.1985  10:15             7.816 CHANGELOG.md
26.10.1985  10:15             1.618 hasSymbols.js
26.10.1985  10:15             1.329 implementation.js
26.10.1985  10:15               532 index.js
26.10.1985  10:15             1.080 LICENSE
16.08.2022  10:10             3.091 package.json
26.10.1985  10:15             1.299 polyfill.js
26.10.1985  10:15             3.647 README.md
26.10.1985  10:15               305 shim.js

In my web application I use the dist\browser.js file direct. Was this not longer supported by your project?

Maybe it is an unintended consequence of the meta change to autogenerate the .npmignore?

ljharb commented 2 years ago

Thanks, that’s exactly what did it. I’ll publish a 4.1.4 in a few hours.

ljharb commented 2 years ago

v4.1.4 is published.

(Please be aware that if we ever have a v5, it will no longer ship a dist, since relying on those is a bad practice - all JS code should be consumed as npm-installed modules bundled by a module bundler)