ljharb / qs

A querystring parser with nesting support
BSD 3-Clause "New" or "Revised" License
8.51k stars 730 forks source link

Add the ability to enable strict RFC 3986 conformance for decoding as well as encoding #205

Open jakepetroules opened 7 years ago

jakepetroules commented 7 years ago

To achieve strict RFC 3986 conformance (specifically, '+' in query strings is a LITERAL '+' and not a placeholder for ' ' as per the W3C's URL recommendations, the following is necessary:

qs.parse(s, {
    decoder: (str) => {
        try {
            return decodeURIComponent(str);
        } catch (e) {
            return str;
        }
    },
})

For those of us who prefer strict RFC 3986 conformance, I suggest an option like:

qs.parse(s, {
    format: 'RFC3986',
})

which would be much more concise and not require knowing the implementation details of the default decode function.

ljharb commented 7 years ago

(related to #163)

Indeed, since stringify supports that option, parse absolutely should as well.