ljharb / qs

A querystring parser with nesting support
BSD 3-Clause "New" or "Revised" License
8.5k stars 729 forks source link

qs.stringify Uncaught RangeError: Cyclic object value #403

Closed Ockejanssen closed 2 years ago

Ockejanssen commented 3 years ago

var qs = require('qs'); var a = ['a']; qs.stringify({x:a,y:a});

-> Uncaught RangeError: Cyclic object value

ljharb commented 3 years ago

This should be fixed in v6.10.1 (see #402). Can you confirm which version of qs you're using?

Ockejanssen commented 3 years ago

I tested this one with "version": "6.10.1"

ljharb commented 3 years ago

Thanks, I can reproduce this.

pober commented 3 years ago

Any updates on this? This affects latest version if superagent module.

ljharb commented 3 years ago

No, I haven't come up with a fix yet. A PR in the meantime would be welcome.

irhamputra commented 2 years ago

Hi @ljharb, i try with umd file with qs@6.10.1, sometimes the bug is still there sometimes not 😕 should i use different version?

ljharb commented 2 years ago

@irhamputra i mean, it's 2021, nobody should be using UMDs for anything - but certainly if the UMD version is different than the real one, that's a bug somewhere.