search

ljharb / qs

A querystring parser with nesting support
BSD 3-Clause "New" or "Revised" License
8.5k stars 729 forks source link

"Cannot read property 'custom' of undefined" in v6.10.x #406

Closed abhinavrastogi-harness closed 1 year ago

abhinavrastogi-harness commented 3 years ago

I'm getting a JS exception after upgrading to the latest version:

Uncaught TypeError: Cannot read property 'custom' of undefined

yarn.lock entry for my dependency:

qs@^6.9.4:
  version "6.10.1"
  resolved "https://registry.yarnpkg.com/qs/-/qs-6.10.1.tgz#4931482fa8d647a5aab799c5271d2133b981fb6a"
  integrity sha512-M528Hph6wsSVOBiYUnGf+K/7w0hNshs/duGsNXPUCLH5XAqjEtiPGwNONLV0tBH8NoGb0mvD5JubnUTrujKDTg==
  dependencies:
    side-channel "^1.0.4"

Another concern is that the bundle size increased by 30kb (because of qs's new dependency side-channel probably) with this upgrade. This one is not a blocker, but definitely a concern.

ljharb commented 3 years ago

What bundler are you using? A couple of them are broken with how they respect the browser field.

The size isn’t a concern; it’s the smallest size that can correctly address the problem it’s solving.

abhinavrastogi-harness commented 3 years ago

I faced this issue while bundling using Rollup.

little3201 commented 3 years ago

the same question too

ljharb commented 3 years ago

If rollup is unable to bundle this package, please file an issue on rollup.

littlecxm commented 2 years ago

has any update? it still happened when I use yarn2 & vite to compile it

Garine519 commented 1 year ago

any updates here?

ljharb commented 1 year ago

I believe this remains an issue with specific bundlers.

If there's something actionable here, i'd be happy to reopen.