search

ljharb / qs

A querystring parser with nesting support
BSD 3-Clause "New" or "Revised" License
8.5k stars 729 forks source link

Update .npmignore #429

Closed udivankin closed 2 years ago

udivankin commented 2 years ago

exclude .editorconfig .eslintignore .eslintrc from bundling to npm package

ljharb commented 2 years ago

Duplicate of #400. Duplicate of #389. Duplicate of #356. Duplicate of #250.

The only files that currently show up in npm pack --dry-run that could be excluded are .github/FUNDING.yml - every other file is 100% necessary in the published package.

udivankin commented 2 years ago

Well, I've read #250 and it still feels a bit weird for me. What about putting a short notice in .gitignore explaining why these were intentionally opted out

ljharb commented 2 years ago

Given that there's an explicit .npmignore file, it seems like a reader should expect that there is a reason without any additional comment, instead of assuming that it's a mistake.

The presence of the .npmignore file hasn't stopped people from filing PRs with the "files" field, and I suspect a comment in either .gitignore or .npmignore would also not achieve the desired effect :-/