ljharb / qs

A querystring parser with nesting support
BSD 3-Clause "New" or "Revised" License
8.5k stars 729 forks source link

fix: allow parsing of empty keys in objects #433

Open Coobaha opened 2 years ago

Coobaha commented 2 years ago

Resolves #432

If we are happy with this implementation and want to proceed:

ljharb commented 2 years ago

There's unlikely to be a major version any time soon; breaking changes just aren't worth it. Configuring it via option is the best bet for now.

codecov[bot] commented 2 years ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a5609c7) 99.80% compared to head (5e70a6a) 99.80%.

:exclamation: Current head 5e70a6a differs from pull request most recent head c077991. Consider uploading reports for the commit c077991 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #433 +/- ## ======================================= Coverage 99.80% 99.80% ======================================= Files 9 9 Lines 1518 1531 +13 Branches 177 179 +2 ======================================= + Hits 1515 1528 +13 Misses 3 3 ``` | [Impacted Files](https://app.codecov.io/gh/ljharb/qs/pull/433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Harband) | Coverage Δ | | |---|---|---| | [test/empty-keys-cases.js](https://app.codecov.io/gh/ljharb/qs/pull/433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Harband#diff-dGVzdC9lbXB0eS1rZXlzLWNhc2VzLmpz) | `100.00% <ø> (ø)` | | | [lib/parse.js](https://app.codecov.io/gh/ljharb/qs/pull/433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Harband#diff-bGliL3BhcnNlLmpz) | `100.00% <100.00%> (ø)` | | | [test/parse.js](https://app.codecov.io/gh/ljharb/qs/pull/433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Harband#diff-dGVzdC9wYXJzZS5qcw==) | `99.80% <100.00%> (+<0.01%)` | :arrow_up: | | [test/stringify.js](https://app.codecov.io/gh/ljharb/qs/pull/433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jordan+Harband#diff-dGVzdC9zdHJpbmdpZnkuanM=) | `99.79% <100.00%> (+<0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.