Closed aks- closed 5 months ago
@ljharb I wonder if we need allowDots
to be true
for encodeDotKeys
and decodeDotKeys
work. Also I can not think of any other name that is similar for parse
and stringify
method. Any suggestions?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.81%. Comparing base (
5f0449f
) to head (867fc7b
).:exclamation: Current head 867fc7b differs from pull request most recent head 30004b2. Consider uploading reports for the commit 30004b2 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ljharb I realised that allowDots = false & encodeDotInKeys
does not break the round-tripping but it does not encode
the dot in key. I just pushed a commit which adjusts the tests and always encodes the key if encodeDotInKeys
is set to true except for the invalid case where the error would be thrown. Can you please take another look?
Previously the dot in the keys would be encoded but the round-tripping was broken. Here is the previous behavior
This PR fixes the above behavior and fixes #249: