Closed wwaaijer-exh closed 4 months ago
lib/parse.js (1)
`17-17`: Change to set `decodeDotInKeys` to `false` aligns with the PR's objective to revert its default behavior. Ensure all dependent parsing functions respect this new default.Verification successful
The script results show that `decodeDotInKeys` is used in several critical places within `lib/parse.js`. Most uses appear to correctly handle the change from `true` to `false`. However, the relationship between `allowDots` and `decodeDotInKeys` needs further investigation to ensure that the new default value does not adversely affect the behavior of `allowDots`. --- The investigation into the interaction between `allowDots` and `decodeDotInKeys` shows that the change in the default value of `decodeDotInKeys` to `false` is handled appropriately. The logic correctly falls back to the default value of `allowDots` when `decodeDotInKeys` is `false`, which is consistent with the intended functionality of the code. This ensures that the behavior of `allowDots` remains predictable and aligned with the new default settings.Scripts Executed
The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Search for all occurrences of `decodeDotInKeys` in the `lib` directory to ensure it's used correctly with the new default. rg 'decodeDotInKeys' ./lib ``` Length of output: 702 --- --- Script: ```shell #!/bin/bash # Examine the logic related to `allowDots` and `decodeDotInKeys` to understand how the change in default value of `decodeDotInKeys` affects `allowDots`. rg 'allowDots' ./lib/parse.js ``` Length of output: 305
Fixes #500.
Restores the default behavior as it was before
v6.12.0
.All test cases with encoded dots explicitly set the relevant options, so the default behavior was not tested. Added an extra test case for this.
Summary by CodeRabbit