Feature list branch protections on def branch

ljharb / repo-report

CLI to list all repos a user has access to, and report on their configuration in aggregate.

MIT License

24 stars 11 forks source link

Feature list branch protections on def branch #12

Closed jakazzy closed 3 years ago

jakazzy commented 3 years ago

This Pull request adds the command for listing the branch protection rules for a default branch of a repository When the command node bin/run branchProtection branch protection rules on the default branch is displayed

allowsForcePushes,
allowsDeletions,
dismissesStaleReviews,
requiredApprovingReviewCount,
requiresApprovingReviews,
requiresCodeOwnerReviews,
pattern

updatebranchprotectionrules

diananova commented 3 years ago

looks good. A few thoughts:

we already have DefBranch in command list. Since there are so many fields here already, we can get rid of it.
there a lot of columns so they overlap each other. Not sure what we can do here to fix this. Maybe we can break it down into 2 different commands? So each table has less columns?
I'm guessing the column 'pattern' looks like this because it doesn't fit on the screen?

jakazzy commented 3 years ago

@diananova sure thanks. Yeah sounds cool. I'll take the def branch. Still figuring out how I can improve on the display