Closed thehanimo closed 3 years ago
Nice one @thehanimo
@thehanimo totally fine to have merged this; but it'd be great to get responses of some kind on my open comments above :-)
@ljharb Sorry about that 😬.. I did make changes as you suggested. Didn't want new features to be branched off from the old main so I went ahead and merged this one. Will make it a point to reply to your comments next time on.
Totally fine to reply later too :-) just want to make sure nothing's forgotten.
@ljharb The remaining comments are on validation. We can open up a new PR for that. @jakazzy wanna take it up?
@thehanimo cool just seeing this.I'll take it up
Add noDiff, noHide and noCollapse flags to detail