search

ljharb / repo-report

CLI to list all repos a user has access to, and report on their configuration in aggregate.
MIT License
24 stars 11 forks source link

Remove `log-symbols` #42

Closed ljharb closed 2 years ago

ljharb commented 2 years ago

Unfortunately this author aggressively drops node support in their packages, and are now dropping CJS support as well - v5 can't work with this project. Let's find an alternative.

thehanimo commented 2 years ago

Hmm. What if we use ✅, ❌ and ⚠️ instead?

ljharb commented 2 years ago

Sure, that sounds much simpler than an entire package for it :-)

thehanimo commented 2 years ago

@ljharb, cli-table was super-weird on my terminal when using emojis (✅, ❌ and ⚠️) which I'm guessing is down to char width. I used unicode characters instead (same as log-symbols). To colour these symbols, I've used colors which is also required by cli-table. Also, log-symbols had fallback symbols based on whether unicode chars were supported or not. Not sure if that is needed here.

P.S. chalk (maintained by the same author) is required by @babel/highlight

ljharb commented 2 years ago

Are we using @babel/highlight in the production code at all? Babel stuff is generally just dev deps.

chalk is going to be a tough one when the author decides to burn the bridge, hopefully its popularity will discourage that and we won't have to face that problem. However, since cli-table uses colors, picking that makes sense.

Re the emojis, it's not a huge deal, but it'd be nice to use them - they look pretty :-)