[Cleanup] Remove unused commands #44

ljharb / repo-report

CLI to list all repos a user has access to, and report on their configuration in aggregate.

MIT License

24 stars 11 forks source link

[Cleanup] Remove unused commands #44 #48

Closed thehanimo closed 2 years ago

thehanimo commented 2 years ago

Remove unused tests
Fix bug with dumpCache
Refactor ls to use the same underlying function as detail

thehanimo commented 2 years ago

Should --cache dump files and folders in the $HOME dir?

ljharb commented 2 years ago

Yes, it should probably use XDG_CACHE_DIR, or failing that, $HOME/.repo-report/, or something?

ljharb commented 2 years ago

This looks great and works great - however, ./bin/run detail didn't error out, like i'd expected it would. Can we fix that?

I also pushed up a commit to fix the schema for one of the metrics. In general, every metric should be nullable, since that means "i explicitly don't care".

thehanimo commented 2 years ago

Yes, it should probably use XDG_CACHE_DIR, or failing that, $HOME/.repo-report/, or something?

Also, --cache is currently only useful for debugging. it doesn't really "cache" API responses.

thehanimo commented 2 years ago

This looks great and works great - however, ./bin/run detail didn't error out, like i'd expected it would. Can we fix that?

I also pushed up a commit to fix the schema for one of the metrics. In general, every metric should be nullable, since that means "i explicitly don't care".

Done!